inject CorruptedDataFilesHandler instead of making it static #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManfredKarrer
approved these changes
Aug 19, 2019
| @@ -137,7 +138,7 @@ public DisputeManager(P2PService p2PService, | |||
| OpenOfferManager openOfferManager, | |||
| KeyRing keyRing, | |||
| PersistenceProtoResolver persistenceProtoResolver, | |||
| @Named(Storage.STORAGE_DIR) File storageDir) { | |||
| @Named(Storage.STORAGE_DIR) File storageDir, CorruptedDatabaseFilesHandler corruptedDatabaseFilesHandler) { | |||
There was a problem hiding this comment.
Can you add a line break. So params are better separated/readable?
There was a problem hiding this comment.
sure, i wonder if there is a way to make idea do it automatically.
|
Just a small thing regarding commit messages. Please start them with uppercase https://chris.beams.io/posts/git-commit/ |
ripcurlx
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a small rabbit-hole that i went down while looking at the code.
storage can probably be injected directly in more places but i didn't want to change any logic in this pr.