Monitor fixes #3045
Merged
Monitor fixes #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it be easy to add some unit tests to this pr? |
|
as the monitor is our least critical infrastructure I rather spend the time fixing stuff in Bisq itself. |
|
At some point in time there should be a rule that any change requires at least simple unit tests. And that time could as well be now. |
|
agreed. however, as we do not have the resources to do all and any testing in an instant we need to spend resources in thoughtful way |
monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshot.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got the monitor to state that is does not kill some of its metrics after a few hours.
Furthermore, I refactored the P2P Roundtriptime metric so it does not always report all seeds as offline if one or more of them takes too long to respond (the issue showed up just recently, seems that our seeds are under heavier load than they have been).