Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #2106 #3039

Closed
wants to merge 1 commit into from
Closed

Fix for #2106 #3039

wants to merge 1 commit into from

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Jul 30, 2019

Added for new columns: Transaction Fee, Maker Fee, Buyer Deposit and Seller Deposit. More can be added on further evaluation against the requirements.

@niyid niyid requested review from ripcurlx and sqrrm as code owners July 30, 2019 22:53
@ManfredKarrer
Copy link
Contributor

Idoubt there is enough space. Can you post a screenshot?

@niyid
Copy link
Contributor Author

niyid commented Jul 31, 2019 •
edited
Loading

Idoubt there is enough space. Can you post a screenshot?

Sure. Find below. Also note that any further additions will be to the CSV export without adding to displayed columns on said screen.
Screenshot from 2019-07-31 16-57-30

@ManfredKarrer
Copy link
Contributor

Thats not the standard size and no values visible. I am pretty shure there is not much available extra space for ne columns....

@niyid
Copy link
Contributor Author

niyid commented Jul 31, 2019

Thats not the standard size and no values visible. I am pretty shure there is not much available extra space for ne columns....

OK. I will just remove the added columns on the screen while retaining them in the export. Thanks.

@niyid
Copy link
Contributor Author

niyid commented Jul 31, 2019 •
edited
Loading

@ManfredKarrer

Now there is a conflict: desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java . Will you resolve or is it something I should do?

@niyid
Copy link
Contributor Author

niyid commented Jul 31, 2019

Please close this and use the PR below. Sorry for any inconvenience.

#3040

@ripcurlx ripcurlx closed this Aug 1, 2019
@froooze froooze mentioned this pull request Aug 2, 2019
Closed
@jmr690 jmr690 mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niyid @ManfredKarrer @ripcurlx