Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempTradingPeerNodeAddress if the trade doesn't have a trading peer set yet #2928

Merged

Conversation

a123b
Copy link
Contributor

@a123b a123b commented Jun 28, 2019

This should fix the errors on the maker side when there's a disagreement
about market price.

Fixes #2910
Fixes #2924

…er set yet

This should fix the errors on the maker side when there's a disagreement
about market price.

Fixes bisq-network#2910
Fixes bisq-network#2924
@a123b a123b requested a review from ripcurlx as a code owner June 28, 2019 11:27
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit e33956c into bisq-network:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while someone took my offer Major errors happening when user tries to accept trade.
3 participants