Add checkbox to hide extreme offers in chart #2884
Conversation
|
since no issue is linked I'll comment here, is this the final solution? Other solutions would be a log scale, or an algorithm to cut off offers which are too far away. Available to brain-storm that algorithm ;) |
|
@mrosseel Not much thought went into this. I just got annoyed with the BSQ market chart being unusable. This solution hides the extreme offers from the chart (more than a factor 5 from the best offers). I don't really want to put much more work into this right now, which the log scale solution probably would be. |
|
Thanks @sqrrm , |
There was a problem hiding this comment.
I personally would just remove the extremes without adding new controls as I don't think there is a use case where someone wants to have this kind of display. If we find time in the future to adapt to a logarithmic scale or similar we can just adapt the code again. Besides that ACK.
|
Removed the checkbox. There is no indication that some offers might not be displayed in the chart now, but I suppose that's ok, it's about usability, not correctness. |
Yes, I understand your concerns, but we had a similar solution in place before (only display the best offers at all), so I think it is OK if we continue to iterate on this over time. |
| @@ -53,6 +53,7 @@ shared.oneOffer=offer | |||
| shared.multipleOffers=offers | |||
| shared.Offer=Offer | |||
| shared.openOffers=open offers | |||
| shared.hideExtremes=Hide extremes | |||
There was a problem hiding this comment.
Please remove the translation as well
| @@ -146,14 +147,20 @@ public OfferBookChartView(OfferBookChartViewModel model, Navigation navigation, | |||
| public void initialize() { | |||
| createListener(); | |||
|
|
|||
| // Header with currency combobox and checkbox to show extreme values | |||
| GridPane topGrid = new GridPane(); | |||
There was a problem hiding this comment.
Please also remove the additional GridPane again, so we don't use more containers as necessary.
|
Removed all the extras except for the column option to a checkbox in FormBuilder. |
No description provided.