Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow seller to take any offers #2813

Merged

Conversation

ManfredKarrer
Copy link
Contributor

No description provided.

Only buyers should be restricted if their account age is too young.
We have one very suspicious case where the trader created his
account on 15. of March. To be more safe to exclude potential scammers
we decrease the check to 1st of march.
@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner May 6, 2019 02:18
@ManfredKarrer ManfredKarrer requested review from sqrrm and devinbileck May 6, 2019 02:18
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - was able to re-produce it with Zelle in current master and it was fixed in this PR.

@ripcurlx
Copy link
Contributor

ripcurlx commented May 6, 2019

☝️ Just improved layout of Zelle buyer form on the way to prevent scrolling

@ripcurlx ripcurlx merged commit 5b70769 into bisq-network:master May 6, 2019
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Looks good

@ripcurlx
Copy link
Contributor

ripcurlx commented May 6, 2019

Just found a little detail that needed to be changed. Translations and references of March 15th needs to be changed to March 1st. And so the release build starts again 😉

@ManfredKarrer ManfredKarrer deleted the allow-seller-to-take-any-offers branch May 8, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants