[WIP] Add protection tools #2787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buyer-has-new-account
31 days was displayed as 31 day.
Implements bisq-network/proposals#77 If fiat trade the buyer need to have an min required account age, otherwise the payout will be delayed.
I think the features is now well known and can be removed. The account age check will add a nde popup so we would get more popup hell if we leave that one...
If offer maker for buying BTC with Fiat has an account selected which is less then the required account age for that method he gets a popup displayed.
# Conflicts: # desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java # desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
# Conflicts: # core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java # desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java
Pure technical refactoring, no functionality change.
Move methods for delayed payout to AccountScore.
We use AccountScoreService as main class which constructs the parameters based on several protection tools. Currently there is only account age based protection.
# Conflicts: # core/src/main/java/bisq/core/app/BisqSetup.java # core/src/main/java/bisq/core/app/misc/AppSetupWithP2P.java # core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java # core/src/main/java/bisq/core/offer/OfferUtil.java # core/src/main/java/bisq/core/proto/CoreProtoResolver.java # core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java # core/src/main/java/bisq/core/trade/Trade.java # core/src/main/java/bisq/core/trade/TradeManager.java # core/src/main/java/bisq/core/trade/TradeModule.java # core/src/main/java/bisq/core/trade/protocol/ProcessModel.java # core/src/main/java/bisq/core/trade/protocol/tasks/VerifyPeersAccountAgeWitness.java # desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java # desktop/src/main/java/bisq/desktop/components/PeerInfoIconSmall.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/AdvancedCashForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/AliPayForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/AssetsForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/BankForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/CashDepositForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/ChaseQuickPayForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/ClearXchangeForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/F2FForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/FasterPaymentsForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralAccountNumberForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralBankForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/GeneralSepaForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/HalCashForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/InteracETransferForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyBeamForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneyGramForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/NationalBankForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/PerfectMoneyForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/PopmoneyForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/PromptPayForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/RevolutForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/SameBankForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/SpecificBankForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/SwishForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/USPostalMoneyOrderForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/UpholdForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/WeChatPayForm.java # desktop/src/main/java/bisq/desktop/components/paymentmethods/WesternUnionForm.java # desktop/src/main/java/bisq/desktop/main/MainViewModel.java # desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java # desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsView.java # desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java # desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java # desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java # desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java # desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java # desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java # desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java # desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java # desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java # desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java # desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java # desktop/src/test/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModelTest.java
Pure technical refactoring, no functional code change
Pure technical refactoring, no functional code change
- Revert earlier changes which applied that check in the general account check.
ripcurlx
reviewed
Apr 30, 2019
ripcurlx
reviewed
Apr 30, 2019
ripcurlx
reviewed
Apr 30, 2019
ripcurlx
reviewed
Apr 30, 2019
core/src/main/java/bisq/core/account/sign/SignedWitnessService.java
Outdated
Show resolved
Hide resolved
Improve restrictions settings in create offer
Even if we would not use it initially it might be good to have it for potential future use.
|
I am considering that implementation approach to be on hold. See bisq-network/proposals#77 (comment) for my concerns with the approach of using a delayed payout. |
|
That approach has been dropped in favor of other ideas (see bisq-network/proposals#78, bisq-network/proposals#83) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #2765 and #2768