Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with DAO full mode in preferences #2736

Conversation

ManfredKarrer
Copy link
Contributor

There was missing the block notify port as well as the options have
not been applied correctly which led to the situation that when you
run the same application in full mode and later in lite mode that
data got persisted.

Added also to the footer a note if full mode is running.

Screen Shot 2019-04-17 at 18 26 50

There was missing the block notify port as well as the options have
not been applied correctly which led to the situation that when you
run the same application in full mode and later in lite mode that
data got persisted.

Added also to the footer a note if full mode is running.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx
Copy link
Contributor

Only conflicts need to be resolved

# Conflicts:
#	common/src/main/proto/pb.proto
#	core/src/main/java/bisq/core/user/Preferences.java
#	core/src/main/java/bisq/core/user/PreferencesPayload.java
#	desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java
@ManfredKarrer ManfredKarrer merged commit f36823f into bisq-network:master Apr 20, 2019
@ManfredKarrer ManfredKarrer deleted the fix-dao-full-mode-settings-issue branch April 20, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants