Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignore list #2733

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix ignore list #2733

merged 2 commits into from
Apr 17, 2019

Conversation

ManfredKarrer
Copy link
Contributor

No description provided.

@ManfredKarrer
Use fullAddress for ignored peers and in peer info
70a950c
@ManfredKarrer
Use full address instead of hostname
683301f 
Mixing usage of host name and full name caused a few bugs in the past.
We should use only full address by default.
@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner April 17, 2019 04:20
@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 17, 2019
ripcurlx
ripcurlx approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit d05bafe into bisq-network:master Apr 17, 2019
@ManfredKarrer ManfredKarrer deleted the fix-ignore-list branch April 17, 2019 23:30
@ripcurlx ripcurlx mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

@devinbileck devinbileck Awaiting requested review from devinbileck

Assignees
No one assigned
Labels
in:gui in:trade-process
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ManfredKarrer @ripcurlx