Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request blocks in case we have not received it #2730

Merged

Conversation

ManfredKarrer
Copy link
Contributor

Once we get a new block from BitcoinJ we start a timer and check in 10
seconds if we have received the block from the P2P network. If not we
request it from the seed nodes.

Once we get a new block from BitcoinJ we start a timer and check in 10
seconds if we have received the block from the P2P network. If not we
request it from the seed nodes.
@ManfredKarrer ManfredKarrer added this to the v1.0.1 milestone Apr 17, 2019
@ManfredKarrer ManfredKarrer requested a review from sqrrm April 17, 2019 01:38
@ManfredKarrer ManfredKarrer modified the milestones: v1.0.1, v1.1.0 Apr 17, 2019
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to ask for the first block we don't have rather than the last block we have.

core/src/main/java/bisq/core/dao/node/lite/LiteNode.java Outdated Show resolved Hide resolved
@ManfredKarrer ManfredKarrer merged commit 2119872 into bisq-network:master Apr 18, 2019
@ManfredKarrer ManfredKarrer deleted the request-block-if-not-received branch April 18, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants