Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAO launch popup #2688

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Conversation

ripcurlx
Copy link
Contributor

Fixes #2632.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner April 10, 2019 13:19
@m52go
Copy link
Contributor

m52go commented Apr 10, 2019

Text suggestions:

popup.dao.launch.headline=The complete vision, realized

popup.dao.launch.trading=Trade BSQ (colored bitcoin) to participate in Bisq governance. You can buy and sell BSQ just like any other asset on Bisq.

For the cheaper fees string, my reworded version is a bit longer. I like it better, but if it's too long to fit in the space we have, we can just use the alternative.

//suggestion (maybe better, but too long?)
popup.dao.launch.cheaperFees=You pay Bisq contributors when you buy BSQ from them. You also get a 90% discount on trading fees by paying with BSQ.\nSave money & support the project by using BSQ!

//alternative (shorter)
popup.dao.launch.cheaperFees=Get a 90% discount on trading fees when you use BSQ. Save money and support the project at the same time!

Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Contributor Author

Updated it for trading
Bildschirmfoto 2019-04-10 um 16 27 22

For cheaper fees I needed to use the shorter variant:
Bildschirmfoto 2019-04-10 um 16 27 32
Bildschirmfoto 2019-04-10 um 16 30 03

@m52go
Copy link
Contributor

m52go commented Apr 10, 2019

Yeah I figured it would be too long. All good!

@ManfredKarrer
Copy link
Contributor

The version on top feels a bit strange to me. It does not fell to be part of the headline but then why its there....

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Apr 10, 2019

The version on top feels a bit strange to me. It does not fell to be part of the headline but then why its there....

The version on top will be 1.0.0 in the release. It should emphasize the version 1.0. I just used the current version atm, so it also works if we decide in the end to go live with 1.0.1. But maybe it should just says static "Bisq v1.0" as in Pedro's design suggested.

Like that:
Bildschirmfoto 2019-04-10 um 16 43 23

@ManfredKarrer
Copy link
Contributor

Screen Shot 2019-04-10 at 09 43 38

Screen Shot 2019-04-10 at 09 43 35

The green colors in the screenshots are a bit different as the app gree.

@ripcurlx
Copy link
Contributor Author

Screen Shot 2019-04-10 at 09 43 38 Screen Shot 2019-04-10 at 09 43 35

The green colors in the screenshots are a bit different as the app gree.

Hmm, true. I did screenshot it from the app, but I guess something went wrong during the export. I'll re-check the source files.

@ManfredKarrer
Copy link
Contributor

For my taste the distance between text and screenshot is a bit too high in relation to other distances.
Maybe the arrows would be a bit closer as well.
I think if we use the version we should use it hard coded with 1.0 as if we need to push an update soon it will be weird (1.0.1 etc). But maybe we shoudl include it more in the headline. Like:
"Bisq 1.0 - The ...."

@ManfredKarrer
Copy link
Contributor

Did you export to jpeg? I think we can keep it png then they are exact.

@ManfredKarrer
Copy link
Contributor

Do you think a sliding animation (left -> right) for the slides is lots of work? The hard cuts are a bit too hard IMO.
Alos maybe the background can be more darkened?

@ripcurlx
Copy link
Contributor Author

Did you export to jpeg? I think we can keep it png then they are exact.

I used png's already - I think it is the fade out that causes the issue in the "cheaper fees" screenshot.

@ripcurlx
Copy link
Contributor Author

I adapted the layout a little bit and changed the last screenshot (it was an optical effect when fading or overlaying with a gradient to white)
Bildschirmfoto 2019-04-10 um 17 35 41
Bildschirmfoto 2019-04-10 um 17 35 36

@ripcurlx
Copy link
Contributor Author

Do you think a sliding animation (left -> right) for the slides is lots of work? The hard cuts are a bit too hard IMO.
Alos maybe the background can be more darkened?

I'm not sure if I'm able to finish it today (I'm off soon). Let's see if I can squeeze in some transition animations.

@ManfredKarrer
Copy link
Contributor

Should link go to DAO webpage or to docs? I think docs might fit better to learn more as DAO webpage is super high level

@ManfredKarrer
Copy link
Contributor

We can merge that and add the animation tomorrow...

@ripcurlx
Copy link
Contributor Author

Should link go to DAO webpage or to docs? I think docs might fit better to learn more as DAO webpage is super high level

You mean this link: https://docs.bisq.network/dao-user-reference.html?

@ManfredKarrer ManfredKarrer merged commit f551bd9 into bisq-network:master Apr 10, 2019
@ripcurlx ripcurlx deleted the add-dao-launch-popup branch September 26, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants