-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DAO launch popup #2688
Add DAO launch popup #2688
Conversation
Text suggestions:
For the cheaper fees string, my reworded version is a bit longer. I like it better, but if it's too long to fit in the space we have, we can just use the alternative.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Yeah I figured it would be too long. All good! |
The version on top feels a bit strange to me. It does not fell to be part of the headline but then why its there.... |
The version on top will be 1.0.0 in the release. It should emphasize the version 1.0. I just used the current version atm, so it also works if we decide in the end to go live with 1.0.1. But maybe it should just says static "Bisq v1.0" as in Pedro's design suggested. |
For my taste the distance between text and screenshot is a bit too high in relation to other distances. |
Did you export to jpeg? I think we can keep it png then they are exact. |
Do you think a sliding animation (left -> right) for the slides is lots of work? The hard cuts are a bit too hard IMO. |
I used png's already - I think it is the fade out that causes the issue in the "cheaper fees" screenshot. |
I'm not sure if I'm able to finish it today (I'm off soon). Let's see if I can squeeze in some transition animations. |
Should link go to DAO webpage or to docs? I think docs might fit better to learn more as DAO webpage is super high level |
We can merge that and add the animation tomorrow... |
You mean this link: https://docs.bisq.network/dao-user-reference.html? |
Fixes #2632.