Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close printWriter before renaming temp file #2669

Conversation

ManfredKarrer
Copy link
Contributor

@ManfredKarrer ManfredKarrer commented Apr 7, 2019

Fixes #2660

@ManfredKarrer ManfredKarrer requested a review from ripcurlx April 7, 2019 19:48
@ManfredKarrer ManfredKarrer added this to the v0.9.8 milestone Apr 7, 2019
@ManfredKarrer ManfredKarrer changed the title Fixes https://github.com/bisq-network/bisq/issues/2660 Close printWriter before renaming temp file Apr 7, 2019
@ManfredKarrer
Copy link
Contributor Author

@BrettCawley could you test on Windows if that fixes it? Assume so as your PR was doing the same at the end... sorry for not pushing it into your PR, just thought its easier that way....

@BrettCawley
Copy link

No worries... Tested and works!

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 33a04bb into bisq-network:master Apr 8, 2019
@ManfredKarrer ManfredKarrer deleted the close-printwriter-before-rename-temp-file branch April 8, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants