Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List ZBit (ZBT) #2573

Closed
wants to merge 2 commits into from
Closed

List ZBit (ZBT) #2573

wants to merge 2 commits into from

Conversation

ssl2
Copy link

@ssl2 ssl2 commented Mar 23, 2019

@ssl2 ssl2 changed the title List Zbit (ZBT) List ZBit (ZBT) Mar 23, 2019
@yiowed
Copy link

yiowed commented Mar 24, 2019

Thanks @ManfredKarrer ! If you need anything, just let us know. We're in the forum too https://bisq.community/t/zbit-pull-request-added-to-repo/7273/2

@ssl2 ssl2 force-pushed the list-zbit-asset branch from 835263f to 0063733 Compare March 25, 2019 03:15
@ssl2 ssl2 requested a review from cbeams as a code owner March 26, 2019 07:14
@ssl2 ssl2 force-pushed the list-zbit-asset branch from 13354d6 to d429949 Compare March 26, 2019 07:37
@ManfredKarrer ManfredKarrer requested review from blabno and removed request for cbeams March 27, 2019 02:52
blabno
blabno reviewed Apr 24, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK per comments

assets/src/main/java/bisq/asset/coins/ZBit.java
public class ZBit extends Coin {

public ZBit() {
super("ZBit", "ZBT", new DefaultAddressValidator());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use deprecated validator.

@blabno
Copy link

blabno commented Apr 24, 2019

do not commit gradle/wrapper/gradle-wrapper.jar

@ripcurlx
Copy link
Contributor

@ssl2 Closing PR because of inactivity. Feel free to re-open when PR requirements are fulfilled.

@ripcurlx ripcurlx closed this Jul 17, 2019
@MidoriDaria MidoriDaria mentioned this pull request Oct 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabno blabno blabno left review comments

Assignees
No one assigned
Labels
in:altcoins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssl2 @yiowed @blabno @ripcurlx @ManfredKarrer