Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BSQ dashboard into separate Facts & Figures section #2513

Merged
merged 7 commits into from
Mar 27, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Mar 7, 2019

~@ManfredKarrer Still in progress as I'll try to add the charts we were talking about as well.
But just to have a fallback scenario PR.

Current state of the "Facts & Figures" section. It sill needs some @pedromvpg love, but for this release it should be good enough I guess.
Bildschirmfoto 2019-03-27 um 15 21 21
Bildschirmfoto 2019-03-27 um 15 09 06
Bildschirmfoto 2019-03-27 um 15 09 20

@ManfredKarrer
Copy link
Contributor

Maybe tab should move right to governance and be called more generic. Ecosystem maybe?

Would be nice to have 2 buttons left:

  • Network
  • Economy

@ManfredKarrer
Copy link
Contributor

@ben-kaufman If you like you could join forces here as well ;-)
@ripcurlx is on holiday next week...

@ben-kaufman
Copy link
Contributor

@ManfredKarrer I'll take a look on that :)

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 8, 2019

Maybe tab should move right to governance and be called more generic. Ecosystem maybe?

Would be nice to have 2 buttons left:

  • Network
  • Economy

The reason why I would have it on the left is that it would open as the default tab when someone clicks on the DAO section. It should be in the end a dashboard with nice graphs and a high-level visualization of the DAO. Otherwise it would be the BSQ Send screen.

To find the right term for this section:

  • What information would be in the network sub-section?

Maybe we could also label it Overview or Fact and Figures?

I was thinking about having in the final version two sub-sections:

  • Dashboard: High-level graphs and nicely presented KPIs
  • Facts or Details: Where we show something like we have right now

In general in the DAO > Facts and Figures > Dashboard should give the user an overview on the amount of BSQ available over time (BSQ colored), how much is burned and the BSQ/BTC conversion rate.
It should be visually very nice layouted (hint to @pedromvpg), so people go into the DAO section because they love to checkout the current state of the DAO.

@ManfredKarrer
Copy link
Contributor

Agree to all you proposed!

@ripcurlx ripcurlx force-pushed the create-dao-section-for-economy branch from fa177e1 to ff21c91 Compare March 27, 2019 14:07
@ripcurlx ripcurlx changed the title [WIP] Move BSQ dashboard in separate economy view Move BSQ dashboard into separate Facts & Figures section Mar 27, 2019
@ripcurlx ripcurlx marked this pull request as ready for review March 27, 2019 14:11
@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner March 27, 2019 14:11
@ripcurlx
Copy link
Contributor Author

@ManfredKarrer It is not perfect, but I think it should be enough for this release. What do you think?

@ManfredKarrer
Copy link
Contributor

Looks goot to me!

Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 2356d2e into bisq-network:master Mar 27, 2019
@ripcurlx ripcurlx deleted the create-dao-section-for-economy branch December 18, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants