Remove libdohj dependency #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarguindzberg
requested review from
cbeams,
ManfredKarrer and
ripcurlx
as code owners
ManfredKarrer
suggested changes
Feb 4, 2019
| @@ -90,8 +88,8 @@ void init(@Nullable Consumer<String> chainFileLockedExceptionHandler, | |||
| Runnable walletPasswordHandler, | |||
| Runnable downloadCompleteHandler, | |||
| Runnable walletInitializedHandler) { | |||
| log.info("Initialize WalletAppSetup with BitcoinJ version {} and LibDohJ version {} with hash of BitcoinJ commit {}", | |||
| VersionMessage.BITCOINJ_VERSION, Version.VERSION, Version.BITCOINJ_VERSION); | |||
| log.info("Initialize WalletAppSetup with BitcoinJ version and hash of BitcoinJ commit {}", | |||
There was a problem hiding this comment.
I think here is missing the {} -> BitcoinJ version {} and
There was a problem hiding this comment.
Beside that, ACK (just tested).
There was a problem hiding this comment.
Done. just force pushed the fix.
ManfredKarrer
requested review from
ripcurlx
and removed request for
ripcurlx and
cbeams
ripcurlx
suggested changes
Feb 5, 2019
oscarguindzberg
force-pushed
the
remove-libdohj
branch
from
f08e174 to
52e3618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove libdohj dependency and the code to use LTC, DASH or DOGE as base currencies.