Surgical fix to default command line parameters #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes #2084 similar to the fix introduced by @cbeams in #2063 (which addressed #2048).
This should get rid of all side-effects we encountered by providing the defaults in the JOptSimple parser already. Since #1961 did not remove any code concerning the "old" default handling this fix should be production ready.
However, as @cbeams mentioned in #1961, he has further changes regarding the command line argument parsing queued up. So
git reverte9ca340 (this commit) andgit revertb122ff4 should prepare Bisq for your queued changes again.