Use same private_key in NewTor and RunningTor mode + Hiddenservice Fix #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2018
|
Please update from master. We just merged the release branch... |
freimair
force-pushed
the
use-same-address-for-native-and-external-tor
branch
from
5d5c4a9 to
15babf1
Compare
freimair
force-pushed
the
use-same-address-for-native-and-external-tor
branch
2 times, most recently
from
ef7ae42 to
4cf18c3
Compare
freimair
force-pushed
the
use-same-address-for-native-and-external-tor
branch
from
4cf18c3 to
6309908
Compare
freimair
changed the title
|
finally, all seems to work as expected. |
|
Will review when back from holiday in January... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in consideration of Export/import feature for onion address #1055 and Feature for renewing the onion address #1056 I enhanced jtorctl to accept the format of the private_key
closes External Tor features does not announce its hidden service #2010. When using the external Tor feature, the hidden service never gets announced to the Tor network. Hence, it takes literally ages until its hidden service is accessible from outside. The new Netlayer+jtorctl releases now actively announce the service to the Tor network.
and there is bad news: jitpack gives me some hard times. It refuses to build the correct commit when a tag is specified (Issue after updating tag jitpack/jitpack.io#3572), so the travis build is expected to fail.
I will give the guys at jitpack a few more days either to come back to me and fix the issue or hopefully, this mysterious caching timeout hits and everything is fine again.