Support handling of removed assets. #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cross check the isCryptoCurrency method if the symbol matches any fiat currency and of both not match consider it still a CC. In case of a removed asset it was returning false before which caused an issue in the trade currency pair showing both sides as BTC. - Show N/A for name in case the asset is not available. The code mostly operates with the ticker symbol which gets stored in the offer, so even an asset is removed traders who have that asset in their account list can trade without problems. Tested create offer, take offer and executing a trade.
Merged
|
Fixing tests and add some changes... |
- We return true at isCryptoCurrency in those cases: - The code is BTC - The code is found in assetRegistry - If not found we check if we have a fiat currency for that code, if not we treat it as crypto (case of a removed asset)
|
As the additional changes have been non trivial I leave it for another ACK. |
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fiat currency and of both not match consider it still a CC. In case of
a removed asset it was returning false before which caused an issue in
the trade currency pair showing both sides as BTC.
The code mostly operates with the ticker symbol which gets stored in
the offer, so even an asset is removed traders who have that asset in
their account list can trade without problems.
Tested create offer, take offer and executing a trade.