Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pricenode gradle build #1890

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

devinbileck
Copy link
Member

As a result of changes done to the gradle build in #1862, I started encountering the following:

> Task :pricenode:jar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pricenode:jar'.
> Could not create ZIP 'C:\Users\Devin\Documents\GitHub\bisq-network\bisq\pricenode\build\libs\pricenode-0.7.2-SNAPSHOT
  .jar'

Issue
It was attempting to generate jar file with LF in filename.

Fix
Make sure to trim whitespace for version variable retrieved from file.

@devinbileck devinbileck requested a review from cbeams as a code owner November 7, 2018 07:48
@ripcurlx
Copy link
Contributor

ripcurlx commented Nov 7, 2018

utACK

Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Not sure why this would occur only after the recent refactoring; the version.txt file nor the code for loading for loading it changed. In any case, the change here looks fine though.

@cbeams cbeams merged commit d910ca6 into bisq-network:master Nov 7, 2018
@cbeams
Copy link
Contributor

cbeams commented Nov 7, 2018

Are you always working / building on a Windows machine, @devinbileck? Would be good to know we have that kind of ‘coverage’.

@devinbileck
Copy link
Member Author

Are you always working / building on a Windows machine

@cbeams Yes. Consider it covered :)

@devinbileck devinbileck deleted the Fix-pricenode-gradle-build branch November 7, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants