Create mono repository #1650
Create mono repository #1650
Conversation
…5b7bd03f7f44e129c97be17 from @chirhonul
|
Please @cbeams and @ManfredKarrer have a look at all the changes. It works for me so far. The only thing that is still open is that |
There was a problem hiding this comment.
ACK. Thanks so much for putting this together, @chirhonul and @ripcurlx.
There are a few changes I'd like to make to the readme regarding instructions for building and importing into IDEA, but don't have the time just now. @ManfredKarrer is traveling, so I'm not sure if he'll have time to review. I'll leave it to you when to merge. I can get my changes in by tomorrow for sure, but they can also be done as a separate PR.
I'll also rearrange the names of the repositories once this is merged, renaming the current bisq-network/bisq to something that gets it out of the way and renaming bisq-network/bisq-desktop to bisq-network/bisq. Sound good?
As I've said before, there are various improvements to the build that we can do to make it a more idiomatic multi-project build, but they can all come afterward. As it is, everything builds and imports cleanly for me (with the right instructions that I'll add to the readme), so thumbs up from my side.
|
I think @ManfredKarrer would be fine with the PR if it works at least already for the two of us. He also knew what @chirhonul came up with in his mono branch. I'll merge it now, as I also want to start merging locally my other two branches I'm working on (redesign, java9/10) with the new structure. |
|
@cbeams The changes you mentioned sound fine with me! Thanks! |
As a follow-on to the monorepo reconsolidation (bisq-network#1650): - Revise and shorten "What is Bisq" section - Remove outdated sections - Remove sections documented elsewhere - Add instructions for building, running and importing into IDEA
As a follow-on to the monorepo reconsolidation (bisq-network#1650): - Revise and shorten "What is Bisq" section - Remove outdated sections - Remove sections documented elsewhere - Add instructions for building, running and importing into IDEA
Based on the RECONSOLIDATION-LOG by @cbeams and the mono branch by @chirhonul.