-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize info icon for funds needed #1316
Finalize info icon for funds needed #1316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When doing a rollover over the icon it does not always work. Sometimes it flickers up quickly but then gets removed. I assume it is an issue with competing rollover handlers (maybe the underlaying text field). I am not so sure if the layout over the textfield is required. We will have the info icon in more places and it will complicate things to lay it over existing components. I would suggest to use the layout where the copy icons are right and the info left and in the next row the open icon under the info icon.
I also preferred the more light green, but leave that to you...
I think we uses "security deposit" instead of "deposit" in all placed. No strong opinion about it but might be good to keep it the same wording.
I also tried already to move it outside the text field box as I recognized the flickering as well. Unfortunately the flickering also occurred there (maybe a little bit less). I'll give it a try by extending the hit area either by some javafx native functionality or by underlying it with a solid color circle that matches the background color and adding the roll over handler for this container. |
I've used the old-school timeout trick to prevent the flickering, decided in the end to use the brighter green again (it is true that it pops more into the eye) and added german translations on the way. |
Still there is a flickering on hiding of the component that occurs no matter if the icon is positioned on (with timeout trick) or outside of the text field (without timeout trick). Haven't found out yet why this happening at all. |
@ManfredKarrer did you see my changes on this PR, in the case that you're already back from flu hell 😉? |
…n-for-funds-needed
…n-for-funds-needed
This will fix #1219