Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transferwise Payment Accounts are created without any Trade Currencies when using bisq-cli #5281

Closed
jimmyneutront opened this issue Mar 6, 2021 · 5 comments
Closed

Transferwise Payment Accounts are created without any Trade Currencies when using bisq-cli #5281

jimmyneutront opened this issue Mar 6, 2021 · 5 comments

Comments

@jimmyneutront
Copy link

Description

When a Transferwise payment account is created using bisq-cli, it is not assigned any trade currencies. Because of this, any offers created using Transferwise as a payment method will not be visible to any takers.

Version

Bisq daemon version 1.5.9 (Linux)
OpenJDK version 11.0.9.1 2020-11-04

Steps to reproduce

  1. Let Alice create a new Transferwise payment account using the 'createpaymentacct' command, which produces the following output: (Note that the 'Currency' field is blank!)
    payment account saved
    Name Currency Payment Method ID
    Tw: [email protected] TRANSFERWISE [alice's tw id here]

  2. Let Bob create a new Transferwise payment account using the 'createpaymentacct' command, which produces the following output:
    payment account saved
    Name Currency Payment Method ID
    Tw: [email protected] TRANSFERWISE [bob's tw id here]

  3. Alice creates an offer to buy BTC with CHF using the 'createoffer' command and her Transferwise payment account ID.

  4. Alice uses the 'getmyoffers' command to view her CHF offers in the BUY direction, and sees the Transferwise offer that she just created.

Expected behaviour

  1. [Expected] Bob should be able to use the 'getoffers' command to view CHF offers in the BUY direction and see Alice's offer as a result.

Actual behaviour

  1. [Reality] Bob uses the 'getoffers' command to view CHF offers in the BUY direction and sees nothing but the message "no BUY CHF offers found"

Additional info

This problem is related to commit #4944 which causes Transferwise payment accounts to be created with no trade currencies by default. Usually, trade currencies are added via checkboxes in the Bisq app, but there is currently no way to add currencies using the API.
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 6, 2021

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

@ghubstan
Copy link
Contributor

ghubstan commented Mar 6, 2021

I will work on this soon.

ghubstan added a commit to ghubstan/bisq that referenced this issue Mar 8, 2021
@ghubstan
Add tradeCurrencies field to Transferwise acct form
b4f4d90 
These changes make tradeCurrencies a required twise acct form field.

Addresses issue bisq-network#5281

- Added comment to PaymentAccountForm about special 'tradeCurrencies' field handling.
- Added support for Transferwise 'tradeCurrencies' to PaymentAccountTypeAdapter.
- Added instance of isTransferwiseAccount check to PaymentAccount.
- Added methods to CurrencyUtil to convert comma delimited code list to TradeCurrency list.
- Added methods to ReflectionUtil for getting fields and methods on class.
- Added required field check to CorePaymentAccountsService.
- Added CreatePaymentAccount test cases.
@ghubstan ghubstan mentioned this issue Mar 8, 2021
Merged
@ghubstan
Copy link
Contributor

ghubstan commented Mar 8, 2021

PR #5284 should resolve this.

@ghubstan
Copy link
Contributor

PR #5284 should close this.

@ripcurlx
Copy link
Contributor

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ripcurlx @ghubstan @jimmyneutront