Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error adding XMR Altcoin account: Address is not a valid XMR address! invalid address prefix 13 #3242

Closed
ifarnung opened this issue Sep 11, 2019 · 7 comments

Comments

@ifarnung
Copy link

Huey in the BISQ Forum recommended I escalate this issue/error. I am trying to add an altcoin account, XMR, and am using a valid address but it is screening it out due to thinking it starts with a 13.

"Address is not a valid XMR address! invalid address prefix 13"

Thanks for any help and sorry if this is in the wrong place, I'm new here,

Attaching screenshot.
image

@battleofwizards
Copy link
Contributor

Thanks for your bug report!

  • Could you please state your Bisq version?
  • Could you please paste your XMR address as text?
  • Does it happen repeatedly for this address or is it a one-time glitch / race condition?

@ifarnung
Copy link
Author

Version 1.1.5
4GdoN7NCTi8a5gZug7PrwZNKjvHFmKeV11L6pNJPgj5QNEHsN6eeX3DaAQFwZ1ufD4LYCZKArktt113W7QjWvQ7CWD1FFMXoYHeE6M55P9
or I also tried (4GdoN7NCTi8a5gZug7PrwZNKjvHFmKeV11L6pNJPgj5QNEHsN6eeX3DaAQFwZ1ufD4LYCZKArktt113W7QjWvQ7CW82yHFEGvSG3NJRNtH)
Happens every time I try it.

Thanks battleofwizards

@battleofwizards
Copy link
Contributor

I can confirm the issue.

Both of your addresses are accepted by Monero GUI but not accepted by Bisq.

@chimp1984
Copy link
Contributor

@ripcurlx That might be worth to try to get into the release.
Buggy validation is a pain....

@ripcurlx
Copy link
Contributor

@xiphon Could you have a look at the Monero validation?

@battleofwizards
Copy link
Contributor

battleofwizards commented Sep 11, 2019

Address validation in Bisq does not support the so called integrated addresses.

As a temporary workaround please use a subaddress.

As a sidenote, in Monero subaddresses are recommended over integrated addresses (but we definitely should support both).

@battleofwizards
Copy link
Contributor

I will submit a fix very soon. Stay tuned.

ripcurlx added a commit that referenced this issue Sep 11, 2019
…ddresses

Add support for Monero integrated addresses; fix #3242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants