Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issue syncing DAO #2825

Closed
oscarguindzberg opened this issue May 13, 2019 · 4 comments · Fixed by #2836
Closed

UI issue syncing DAO #2825

oscarguindzberg opened this issue May 13, 2019 · 4 comments · Fixed by #2836
Labels

Comments

@oscarguindzberg
Copy link
Contributor

oscarguindzberg commented May 13, 2019

Steps to reproduce:

  • Do a restore from seed with a date back in 2018
  • Go to DAO / BSQ Wallet / Transactions

Result

  • Label says "Awaiting blocks... Verified 575,868 blocks out of 554,857"
    554,857 is an example, the number increases as new blocks arrive.

Expected

  • Label says "Awaiting blocks... Verified 554,857 blocks out of 575,868"

Screen Shot 2019-05-13 at 12 48 05

@ManfredKarrer
Copy link
Contributor

ManfredKarrer commented May 14, 2019

It should repeat BSQ block requests if new BitcoinJ blockes arrived during parsing BSQ blocks, but seems there are unhandled cases. I also saw when I started with a fresh app with an old wallet that sometimes the sync took either very long or did not finish. Restarting usually resolved it.

@oscarguindzberg
Copy link
Contributor Author

it is just a ui thing,
Label says "Awaiting blocks... Verified X blocks out of Y"
Label should say "Awaiting blocks... Verified Y blocks out of X"

@ManfredKarrer
Copy link
Contributor

ManfredKarrer commented May 15, 2019

I am not sure. It can be that the app gets BSQ blocks up to 575,868 from the seed nodes but bitcoinJ has still not received all blocks and is behind that. I assume that is the issue, but might be wrong as well... its a bit cumbersome to test/simulate...

We have here 2 data sources. We request BSQ blocks from seed nodes, they are delivering blocks up to latest block. We also get the latest blockheight from bitcoinJ which is usually the target height but if BitcoinJ is still syncing it can be behind. Normally BitcoinJ sync is faster then the BSQ sync but can be situations where it is not. Maybe we should overwrite the target block (right side) as soon we received response of BSQ blocks and therefore know what is the latest block even if BitcoinJ is behind that.

@devinbileck
Copy link
Member

I believe you are right @ManfredKarrer. I can reproduce the issue and have a fix pending.

devinbileck added a commit to devinbileck/bisq that referenced this issue May 16, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
After restoring from seed, the text shown under DAO /
BSQ Wallet / Transactions displays an incorrect progress - the numbers
are swapped. For example:
"Awaiting blocks... Verified 575,868 blocks out of 554,857"

Normally we get the latest block height from BitcoinJ as the
target height, and we request BSQ blocks from seed nodes up to latest
block.

But when restoring from seed, we receive the latest block height
from the seed nodes while BitcoinJ has not received all blocks yet and
is still syncing.

Fixes bisq-network#2825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants