Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer Book screen does not reflow contents as expected #1587

Closed
cbeams opened this issue Jun 26, 2018 · 0 comments
Closed

Offer Book screen does not reflow contents as expected #1587

cbeams opened this issue Jun 26, 2018 · 0 comments
Assignees
Milestone

Comments

@cbeams
Copy link
Contributor

cbeams commented Jun 26, 2018

Repro steps

  1. Open Bisq
  2. Navigate to a screen other than Offer Book
  3. Maximize the window
  4. Navigate back to the Offer Book screen
  5. Notice that contents do not reflow, as seen in the screenshot below:

image

Workaround

Explicitly resize the window once again, while remaining on the Offer Book screen. Notice that contents do reflow as expected:

image

Notes

There probably needs to be a check in the Offer Book's activation logic to see whether the window dimensions have changed, and to force a reflow. Not sure if it can be that simple, but seems logical.

There still seems to be a bit of wasted real estate even after the reflow occurs. Not strictly part of this bug, but worth mentioning it in context.

The ability to reflow at all on this screen is new in v0.7.0, so not too surprising that there are some rough edges to smooth out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants