-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bisq fee setting big bug #1325
Comments
Ok, I make this bug report simple - I set the fee 5 sat/B I paid 26.042 sat/B - 5x more - so there is an error somewhere? |
maybe problem with how information is presented in log, I also see multiple times a useless debug of "a fee of 0.00 BTC/kB " e.g here:
|
From bisq.log: |
@montvid Yes seem there is a bug in the fee estimation. Can you post the part of the log of the complete transaction? |
Hi,m I hope this is enough: Feb-04 16:55:10.656 [JavaFX-Launcher] INFO i.b.g.a.BisqApp: Log files under: /home/monika/.local/share/Bisq/bisq Feb-04 16:55:26.282 [ STARTING] INFO i.b.c.b.w.WalletConfig: We try to connect to 9 btc nodes Feb-04 16:56:55.634 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.635 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.640 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.640 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.645 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.645 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.651 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.652 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.656 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.656 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.661 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.661 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.667 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.668 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.674 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.674 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.681 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.681 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:56:55.687 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:56:55.687 [JavaFX Application Thread] ERROR i.b.c.b.w.BtcWalletService: Could not calculate the fee. Tx= 217712ce7d7ab0f623e7ef2733d1958abb66caaf5a41bf88bc37ab8949970bf3 Feb-04 16:56:55.688 [JavaFX Application Thread] INFO i.b.g.m.f.w.WithdrawalView: Fee for tx with size 192: 0.00005 BTC Feb-04 16:58:19.971 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:19.972 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:19.983 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:19.983 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:19.988 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:19.989 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:19.993 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:19.993 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:19.997 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:19.997 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:20.000 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:20.001 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:20.004 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:20.004 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:20.009 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:20.009 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:20.012 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:20.013 [JavaFX Application Thread] INFO o.b.w.Wallet: Completing send tx with 1 outputs totalling 0.001177 BTC and a fee of 0.00 BTC/kB Feb-04 16:58:20.016 [JavaFX Application Thread] INFO i.b.c.b.w.WalletService: Feb-04 16:58:20.016 [JavaFX Application Thread] ERROR i.b.c.b.w.BtcWalletService: Could not calculate the fee. Tx= 217712ce7d7ab0f623e7ef2733d1958abb66caaf5a41bf88bc37ab8949970bf3 Feb-04 16:58:20.016 [JavaFX Application Thread] INFO i.b.g.m.f.w.WithdrawalView: Fee for tx with size 192: 0.00005 BTC Feb-04 16:58:32.499 [JavaFX Application Thread] INFO o.b.w.Wallet: commitTx of a85e03dbe2ff3082039ba5b17a9d644fb593604ce2818b4da72950ad7e71f99d |
AS I said before I set the fee manually to 5 sat/b but bisq did a 26 sat/b tx - it should have been 5 sat/b. |
I found the issue: |
Will close that as it is fixed with next release. |
@ManfredKarrer what should be done in such case in case of withdrawal (not 2 sides transction) to external wallet? Will simply deleting SPV state help or it will complicate it even more? |
With current app the min fee is 0.00005 btc with is about 26 sat/byte. There is no work around for that beside using the release branch (https://github.com/bisq-network/exchange/tree/release-candidate-0.6.6) and build from that. |
But that is 50 cent, so should not be a terrible issue... |
Thanks for the fix. Well if bisq sets the fee automaticaly to 100 sat/b and you then pay 5x times more like 500 sat/b then there is a problem. Or is it just a bug with 5 sat/b? I have to check my logs... |
No it was just a too high min. fee. Instead of taking 5000 sat/kb (min relay fee) it was using 5000 sat as fixed min. fee without calculating it with tx size. Larger tx are correct, just with small tx it was too high. |
Hi, I set manually the bisq fee to 5 "satoshi/byte" but I got a 26.042 sat/B transaction by paying 0.00005 BTC for ONE transaction. So there is an error - I guess the old code was counting "satoshi/kilobyte" like the bitcoin core client does. The other problem I can't set the fees to lower than 5 so I was unable to go around the bug. As you may know the mempool accepts <10 sat/b tx now but bisq does not the lowest is 26.042 sat/B!
https://blockchain.info/tx/a85e03dbe2ff3082039ba5b17a9d644fb593604ce2818b4da72950ad7e71f99d
The text was updated successfully, but these errors were encountered: