-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer additional information/hints whereever price distance in % (dynamic pricing) is used #1214
Comments
Of course most of the time it will be red underlays and no underlay if the price distance is 0% |
See #1203 (comment) how this could be done for the create offer screen. |
What would the content of the (i) "popup" be? How would you explain this difference. |
@GuiSim Did you see my comment from the other issue #1203 (comment)? It wouldn't be an (i) icon, but just the sync icon and on roll over we have enough space to explain the exact details on this dynamic price distance offer. |
I had missed that. Would you prefer to have comments on this tooltip here? I still feel like it's not super clear what "below the market price" really entails. I had written some comments in #1191 (comment) but essentially I wonder if the text should be different if you're buying VS selling. I would also suggest that instead of saying "and updated every minute" it could say "This offer is 2% below the market price as of "Updated every minute" could be a setting or explained elsewhere, it doesn't have to be on every line. Overall I think this proposal is a great step in the right direction. I hope my feedback can be useful! |
Yes, to update the text live might be a good way to even indicate when exactly the price changed. Maybe for "Sell BTC": "Buy BTC": |
Very good ideas 👍 |
Not sure if putting the tab button above is the best place as the text field headline is in between and makes the visual connection of the tab button with the below text fields less clear. |
The reason why I've put it on top is to have more connection with the textfields ;-). We could even colorize the section below, but actually I like the idea of getting rid of them completely. I'll create a mockup to see, if it might be enough to work with placeholder text and icons next to the input fields. I'm not sure if it make sense to add the BitcoinAverage/Poloniex icon into the mix as I guess hardly anyone would recognize these logos. |
One more thing I just recognized. Why do we have an amount range (min, max) on the left side, but no amount range in USD on the right side? Isn‘t that confusing that we are not communicating the range you might have to pay there as well? In general I want to get rid of the range selection by default anyways, but atm I think it‘s not very consistent. I‘ll post new screens tomorrow morning. |
@ripcurlx Yes agree that BitcoinAverage/Poloniex icons will probably not be a good idea, also we might create our own price mix one day... |
I would phrase it more like that: |
Good suggestion 👍 - so it works for both scenarios. |
@GuiSim and @tr37ion: How do you like #1214 (comment) and #1214 (comment) in the create offer screen? I slowly want to move this issue into a ready-for-development state, so it will be part of v0.7.0. |
To me #1214 (comment) is the most appealing as the cross marks the choice the best. Adding those info tooltips is always a plus. |
@tr37ion if I understand this correctly, the 2nd screenshot is just the result of clicking the I think it's okay but I think it's somewhat confusing. I didn't spend much time focusing on this part of the application (I mostly thought about how the buy/sell table was displayed). I think that to me it would make more sense if the flow was like this: Do you want to sell an exact amount of BTC or a range? If it's exact, prompt only for one amount. I know this is challenging what has been discussed so far and I'm sorry this feedback comes in late. Though to be honest I didn't plan to participate in this discussion until you pinged me ;) If it's too far off and not relevant, please ignore. I don't want to waste your time with this, just my 2¢. |
@ripcurlx Maybe a slider component might work to satisfy the issue? If the user set min. amount above 0.00625 BTC we could show a popup telling the background that new users has that limit and if he set min. amount higher he excluded those users. |
@GuiSim It's never too late for feedback 😉 General Changes compared to current version:
Changes for selling fixed amount:
Changes for selling amount range:
I've added the minimum and maximum wording in this view to make it more consistent with the min-max used on other places within the app. |
@ripcurlx Graphically it looks good to me. Only small suggestion is to move the blue swap button up to the middle of the 2 rows. But up to you... What if we suggest by default a min. of 0.0625 (e.g. the min. for that payment account) and if the user increases that he gets a one time popup where the reasoning behind is explained (fewer potential takers). We still can keep the +/- buttons but just use default the state where the min. amount is visible and filled with the payment accounts limit for the first month (25% of payment method limit). What do you think? |
Here is my suggestion for the min amount handling in more details: So to summarize it will require 3 new preference entries:
The useMinLimit is reflected as checkbock in general preferences. |
I decided in the first iteration against having the exchange arrows in the middle and adding the extra space before the equal sign as I liked it better that way. But of course up for discussions. For trying it out please see #1477 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
There are multiple places in the app where the a percentage number is shown next to the price or can be entered. Although we display e.g. in the create offer screen that you can enter the "Distance in % from the market price" it is not explained if this will adapt if the bitcoin price is changing. Also the user might not be 100% sure if the BitcoinAverage price will be used or another price feed. One solution could be to add a (i) icon next to the input field displaying this information. The same can be done in tables where we display the price e.g. 8020 (4%) --> add an (i) icon next to the percentage explaining the reasoning behind this number.
The text was updated successfully, but these errors were encountered: