Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer additional information/hints whereever price distance in % (dynamic pricing) is used #1214

Closed
ripcurlx opened this issue Jan 18, 2018 · 35 comments
Assignees

Comments

@ripcurlx
Copy link
Contributor

There are multiple places in the app where the a percentage number is shown next to the price or can be entered. Although we display e.g. in the create offer screen that you can enter the "Distance in % from the market price" it is not explained if this will adapt if the bitcoin price is changing. Also the user might not be 100% sure if the BitcoinAverage price will be used or another price feed. One solution could be to add a (i) icon next to the input field displaying this information. The same can be done in tables where we display the price e.g. 8020 (4%) --> add an (i) icon next to the percentage explaining the reasoning behind this number.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Feb 7, 2018

If we render a bar underneath the price itself for the price distance/spread it could look like this. Red would mean price distance is negative for the offer taker and green means it is positive for the offer taker.
sell screen

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Feb 7, 2018

Of course most of the time it will be red underlays and no underlay if the price distance is 0%

@ripcurlx
Copy link
Contributor Author

See #1203 (comment) how this could be done for the create offer screen.

@GuiSim
Copy link

GuiSim commented Feb 27, 2018

What would the content of the (i) "popup" be? How would you explain this difference.

@ripcurlx
Copy link
Contributor Author

@GuiSim Did you see my comment from the other issue #1203 (comment)? It wouldn't be an (i) icon, but just the sync icon and on roll over we have enough space to explain the exact details on this dynamic price distance offer.
sell screen no flags

@GuiSim
Copy link

GuiSim commented Feb 27, 2018

I had missed that. Would you prefer to have comments on this tooltip here?

I still feel like it's not super clear what "below the market price" really entails. I had written some comments in #1191 (comment) but essentially I wonder if the text should be different if you're buying VS selling.

I would also suggest that instead of saying "and updated every minute" it could say "This offer is 2% below the market price as of X seconds ago." or similar. This would make it more obvious when was the last update and also would make it more apparent that the sync button worked.

"Updated every minute" could be a setting or explained elsewhere, it doesn't have to be on every line.

Overall I think this proposal is a great step in the right direction. I hope my feedback can be useful!
What do you think?

@ripcurlx
Copy link
Contributor Author

Yes, to update the text live might be a good way to even indicate when exactly the price changed.
We can and should have different descriptions for buy and sell offers. Now we have the space to make it absolutely clear to the user.

Maybe for "Sell BTC":
This offer is 2% below the market price (last update 20 seconds ago). You are getting less than the market price when taking this offer.

"Buy BTC":
This offer is 2% below the market price (last update 20 seconds ago). You are paying less than the market price when taking this offer.

@ripcurlx
Copy link
Contributor Author

We could also use the sync icon within the create offer screen and re-order the fields a little bit. With the green (i) or orange warning we could show in the tooltip what this percentage means for the buyer/seller.
create offer
create offer with warning

@GuiSim
Copy link

GuiSim commented Feb 27, 2018

Very good ideas 👍

@ripcurlx
Copy link
Contributor Author

The roll-over popups for creating a buy offer could say something like:
Buy below market price (2% distance)
buy below market price
Buy at market price (0% distance)
buy at market price
Buy above market price (-2% distance)
buy above market price

@ripcurlx
Copy link
Contributor Author

And the same roll-over popups for creating a sell offer:
Sell above market price (2% distance)
create sell offer plus 2 percent
Sell at market price (0% distance)
create sell offer zero percentage
Sell below market price (-2% distance)
create sell offer minus 2 percent

@ripcurlx
Copy link
Contributor Author

For fixed offers I don't think we need additional information. Similar to the percentage scenario I just disabled the input field below, so it's not so confusing where you need/should change values. What do you think?
create offer fixed

@tr37ion
Copy link

tr37ion commented Feb 28, 2018

Good ideas. Can you add a bit more space here?

image

@ManfredKarrer
Copy link
Contributor

ManfredKarrer commented Mar 1, 2018

Not sure if putting the tab button above is the best place as the text field headline is in between and makes the visual connection of the tab button with the below text fields less clear.
Maybe we could make the icons for "Percentage" and "Fixed" a part of the text input+currency combo fields and add a swap button in between on the right so the user can swap between the 2 options? The "Percentage" and "Fixed" text can be part of the label description (is partly already). The not active (2nd row) label description cold be also greyed out so it becomes more clear that its not active part.
Maybe the % icon can be a combination of the BitcoinAverage/Poloniex and something liker here: https://www.iconfinder.com/icons/189569/label_percentage_price_sale_shop_shopping_tag_icon#size=512 (probably too large)?
Though I also fear that the BitcoinAverage/Poloniex icon are too big and attract to much attention as they are colored....

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 1, 2018

The reason why I've put it on top is to have more connection with the textfields ;-). We could even colorize the section below, but actually I like the idea of getting rid of them completely. I'll create a mockup to see, if it might be enough to work with placeholder text and icons next to the input fields. I'm not sure if it make sense to add the BitcoinAverage/Poloniex icon into the mix as I guess hardly anyone would recognize these logos.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 1, 2018

One more thing I just recognized. Why do we have an amount range (min, max) on the left side, but no amount range in USD on the right side? Isn‘t that confusing that we are not communicating the range you might have to pay there as well? In general I want to get rid of the range selection by default anyways, but atm I think it‘s not very consistent. I‘ll post new screens tomorrow morning.

@ManfredKarrer
Copy link
Contributor

@ripcurlx Yes agree that BitcoinAverage/Poloniex icons will probably not be a good idea, also we might create our own price mix one day...
To use the placeholder text for explaining what % and fixed is is a good idea. Its partly already but text could be improved.
Re range: Yes agree. If you find a way how to do it without overloading the UI would be good. Though as nobody to my knowledge requested that and also myself never thought on that, I am not sure if its really a missing feature?
Maybe the range could be replaced by a more visual component like a progressbar where u can set start and end range. That would be limited automatically by the trade limits. Of course text fields are required as well as some want to edit it exactly to a specific number. But such a component might be then also used on the counter currency side (fiat/altcoin).

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 2, 2018

I just removed the range by default for now (will improved with selector soon) and played around with the idea not having the tabs at all. We could think about using radio buttons for selection instead. What do you think?
create sell offer reduced

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 6, 2018

Or without RadioButtons like that:
create sell offer reduced

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 6, 2018

And if you want to add a minimum amount it could look like this:
create sell offer reduced range

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 7, 2018

Changed the style of "add min. amount" a little bit and added a tooltip how the information for this range feature could look like.
create sell offer reduced

@ManfredKarrer
Copy link
Contributor

I would phrase it more like that:
"Defining a minimum amount increases the chance your offer gets taken faster as the taker can choose any amount within the given range."
If you use buyer ore seller then u need to use opposite of what user is doing, e.g. here its the seller. I think taker might be less confusing...

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 8, 2018

Good suggestion 👍 - so it works for both scenarios.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 9, 2018

@GuiSim and @tr37ion: How do you like #1214 (comment) and #1214 (comment) in the create offer screen? I slowly want to move this issue into a ready-for-development state, so it will be part of v0.7.0.

@tr37ion
Copy link

tr37ion commented Mar 9, 2018

To me #1214 (comment) is the most appealing as the cross marks the choice the best. Adding those info tooltips is always a plus.

@GuiSim
Copy link

GuiSim commented Mar 9, 2018

@tr37ion if I understand this correctly, the 2nd screenshot is just the result of clicking the + in the first screenshot.

I think it's okay but I think it's somewhat confusing. I didn't spend much time focusing on this part of the application (I mostly thought about how the buy/sell table was displayed).

I think that to me it would make more sense if the flow was like this:

Do you want to sell an exact amount of BTC or a range?

If it's exact, prompt only for one amount.
If it's a range, prompt for a min and a max.

I know this is challenging what has been discussed so far and I'm sorry this feedback comes in late. Though to be honest I didn't plan to participate in this discussion until you pinged me ;)

If it's too far off and not relevant, please ignore. I don't want to waste your time with this, just my 2¢.

@ManfredKarrer
Copy link
Contributor

@ripcurlx
I basically like the last screen graphically but I am not sure if hiding the min amount is really the best way. See #1444 for the reason of my concerns...

Maybe a slider component might work to satisfy the issue? If the user set min. amount above 0.00625 BTC we could show a popup telling the background that new users has that limit and if he set min. amount higher he excluded those users.

@tr37ion
Copy link

tr37ion commented Mar 10, 2018

A slider like this one?

image

@ripcurlx
Copy link
Contributor Author

@GuiSim It's never too late for feedback 😉
Reading through all the suggestions I think we should split this issue up further to prevent a gigantic change in this view. I want to give the min/max amount combined with the trade-limit issue some time to work it out properly and start implementing the fixed/dynamic part first. Still I want to hide the min amount by default, as it was super confusing to me when I saw it the first time. Also as I didn't understand it seeing it for the first time, I didn't use it on my first offer. The additional advantage of hiding it is, that we have the chance to communicate in more detail in the pop over why it makes sense to set an amount range.

General Changes compared to current version:

  • New selection for fixed/dynamic price

Changes for selling fixed amount:

  • Label "Fixed amount of BTC to sell" instead of "Amount of BTC to sell"
  • Hide Minimum amount by default (@tr37ion I used the plus circle as we already use the circle style (e.g. minus) on other places within the app)
    create sell offer fixed amount

Changes for selling amount range:

  • Label "Maximum amount of BTC" instead of "Amount of BTC to sell"
  • Added Minimum amount of BTC that can be removed again by clicking on the minus circle icon
  • Label "Maximum amount in USD" instead of "Amount in USD to receive"
  • Added Minimum amount in USD

I've added the minimum and maximum wording in this view to make it more consistent with the min-max used on other places within the app.

create sell offer amount range

@ManfredKarrer
Copy link
Contributor

@ripcurlx Graphically it looks good to me. Only small suggestion is to move the blue swap button up to the middle of the 2 rows. But up to you...
I still have concerns if the hiding of the min. amount field has negative effects as offers without a lower min amount might not be accessible for new users with the low 0.0625 BTC limit in the first month.

What if we suggest by default a min. of 0.0625 (e.g. the min. for that payment account) and if the user increases that he gets a one time popup where the reasoning behind is explained (fewer potential takers). We still can keep the +/- buttons but just use default the state where the min. amount is visible and filled with the payment accounts limit for the first month (25% of payment method limit).
The state change the user is doing (e.g. remove the min amount or set it higher or lower could be persisted in the preferences and next time get applied so we don't bother him if he does not follow the suggestion.

What do you think?

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Mar 26, 2018

I do understand your concerns regarding the minimum amount issue, that might exclude new traders from the opportunity to take most of the available offers. I thought there might be an intermediate step before we've to make bigger changes within this screen, but I think we need to fix this properly in one step.

Until we'll have a good solution for the amount/limit problem, I'll make the changes for Fixed|Percentage first. I've put the swap sign at the bottom field, as I remembered it like that in Google Maps, but after revisiting it I saw that they just put it there as they needed an icon next to the field above as well.
So the next iteration will look like that:
create sell offer market price margin

@ManfredKarrer
Copy link
Contributor

Here is my suggestion for the min amount handling in more details:
We could use a preferences checkbox for "Set min. amount to not exclude new users with min. trade limit". If that flag is set (default its true) then the min. amount is always the 0.25% of the payment methods trade limit. If the user changes the min. amount the first time he gets a popup explaining the context and asking if he wants to change that flag and if he wants to keep min amount to max amount we remember that and show the + icon and don't show the min amount fields. If he changes it the min. amount he entered will be persisted and applied to new offers. E.g. if he sets it to 0.01 his next offer will have set it automatically to 0.01 as well. If he sets it to max. the next offer will have it to max again.

So to summarize it will require 3 new preference entries:

  • boolean useMinLimit
  • boolean dontUseMinAmount
  • long preferredMinAmount

The useMinLimit is reflected as checkbock in general preferences.
dontUseMinAmount is set to true if user set min amount to max amount (in first time popup the user can set that in the dialoge).
If min amount is set the preferredMinAmount is set. The preferredMinAmount must be checked with the amount field as it is now to not have larger preferredMinAmount than amount. But we only persist changes of preferredMinAmount which have been entered by the user not which have been set by the app from input validation.

@ripcurlx
Copy link
Contributor Author

I decided in the first iteration against having the exchange arrows in the middle and adding the extra space before the equal sign as I liked it better that way. But of course up for discussions. For trying it out please see #1477

@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 17, 2019
@stale
Copy link

stale bot commented Jan 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants