Code polishing to make Codacy happier

bisq-network · Sep 15, 2020 · f8e202e · f8e202e
1 parent 4f3ccda
commit f8e202e
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 20 deletions.
diff --git a/assets/src/main/java/bisq/asset/Base58BitcoinAddressValidator.java b/assets/src/main/java/bisq/asset/Base58BitcoinAddressValidator.java
@@ -17,7 +17,6 @@
 
 package bisq.asset;
 
-import org.bitcoinj.core.Address;
 import org.bitcoinj.core.AddressFormatException;
 import org.bitcoinj.core.LegacyAddress;
 import org.bitcoinj.core.NetworkParameters;

diff --git a/core/src/main/java/bisq/core/btc/setup/BisqKeyChainFactory.java b/core/src/main/java/bisq/core/btc/setup/BisqKeyChainFactory.java
@@ -24,7 +24,6 @@
 import org.bitcoinj.wallet.DefaultKeyChainFactory;
 import org.bitcoinj.wallet.DeterministicKeyChain;
 import org.bitcoinj.wallet.DeterministicSeed;
-import org.bitcoinj.wallet.KeyChainFactory;
 import org.bitcoinj.wallet.KeyChainGroupStructure;
 import org.bitcoinj.wallet.Protos;
 import org.bitcoinj.wallet.UnreadableWalletException;

diff --git a/core/src/main/java/bisq/core/btc/setup/WalletConfig.java b/core/src/main/java/bisq/core/btc/setup/WalletConfig.java
@@ -523,18 +523,18 @@ private void maybeMoveOldWalletOutOfTheWay(File walletFile) {
      * As soon as the transaction broadcaster han been created we will pass it to the
      * payment channel extensions
      */
-//    private void completeExtensionInitiations(TransactionBroadcaster transactionBroadcaster) {
-//        StoredPaymentChannelClientStates clientStoredChannels = (StoredPaymentChannelClientStates)
-//                vWallet.getExtensions().get(StoredPaymentChannelClientStates.class.getName());
-//        if(clientStoredChannels != null) {
-//            clientStoredChannels.setTransactionBroadcaster(transactionBroadcaster);
-//        }
-//        StoredPaymentChannelServerStates serverStoredChannels = (StoredPaymentChannelServerStates)
-//                vWallet.getExtensions().get(StoredPaymentChannelServerStates.class.getName());
-//        if(serverStoredChannels != null) {
-//            serverStoredChannels.setTransactionBroadcaster(transactionBroadcaster);
-//        }
-//    }
+    // private void completeExtensionInitiations(TransactionBroadcaster transactionBroadcaster) {
+    //     StoredPaymentChannelClientStates clientStoredChannels = (StoredPaymentChannelClientStates)
+    //             vWallet.getExtensions().get(StoredPaymentChannelClientStates.class.getName());
+    //     if(clientStoredChannels != null) {
+    //         clientStoredChannels.setTransactionBroadcaster(transactionBroadcaster);
+    //     }
+    //     StoredPaymentChannelServerStates serverStoredChannels = (StoredPaymentChannelServerStates)
+    //             vWallet.getExtensions().get(StoredPaymentChannelServerStates.class.getName());
+    //     if(serverStoredChannels != null) {
+    //         serverStoredChannels.setTransactionBroadcaster(transactionBroadcaster);
+    //     }
+    // }
 
     private PeerGroup createPeerGroup() {
         PeerGroup peerGroup;

diff --git a/core/src/main/java/bisq/core/util/validation/BtcAddressValidator.java b/core/src/main/java/bisq/core/util/validation/BtcAddressValidator.java
@@ -21,7 +21,6 @@
 
 import bisq.common.config.Config;
 
-import org.bitcoinj.core.Address;
 import org.bitcoinj.core.AddressFormatException;
 import org.bitcoinj.core.LegacyAddress;
 

diff --git a/core/src/test/java/bisq/core/btc/nodes/BtcNodeConverterTest.java b/core/src/test/java/bisq/core/btc/nodes/BtcNodeConverterTest.java
@@ -29,11 +29,9 @@
 import java.net.InetAddress;
 import java.net.UnknownHostException;
 
-import org.junit.Ignore;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.mock;

diff --git a/desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java b/desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java
@@ -80,7 +80,6 @@
 import javafx.util.Callback;
 
 import java.util.Comparator;
-import java.util.List;
 
 import javax.annotation.Nullable;
 

diff --git a/desktop/src/main/java/bisq/desktop/util/GUIUtil.java b/desktop/src/main/java/bisq/desktop/util/GUIUtil.java
@@ -68,7 +68,6 @@
 import bisq.common.util.Tuple3;
 import bisq.common.util.Utilities;
 
-import org.bitcoinj.core.Address;
 import org.bitcoinj.core.Coin;
 import org.bitcoinj.core.LegacyAddress;
 import org.bitcoinj.core.TransactionConfidence;

diff --git a/monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshotBase.java b/monitor/src/main/java/bisq/monitor/metric/P2PSeedNodeSnapshotBase.java
@@ -164,7 +164,7 @@ public void onFailure(@NotNull Throwable throwable) {
 
     @Override
     public void onMessage(NetworkEnvelope networkEnvelope, Connection connection) {
-        if(treatMessage(networkEnvelope, connection)) {
+        if (treatMessage(networkEnvelope, connection)) {
             gate.proceed();
         } else if (networkEnvelope instanceof CloseConnectionMessage) {
             gate.unlock();