Merge pull request #3978 from ripcurlx/accept-empty-option-values

Accept empty config values
bisq-network · Feb 17, 2020 · c411f48 · c411f48
2 parents a3f4f7c + 3899f69
commit c411f48
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/common/src/main/java/bisq/common/config/ConfigFileOption.java b/common/src/main/java/bisq/common/config/ConfigFileOption.java
@@ -20,7 +20,7 @@ public static ConfigFileOption parse(String option) {
 
         String[] tokens = clean(option).split("=");
         String name = tokens[0].trim();
-        String arg = tokens[1].trim();
+        String arg = tokens.length > 1 ? tokens[1].trim() : "";
         return new ConfigFileOption(name, arg);
     }
 

diff --git a/common/src/test/java/bisq/common/config/ConfigFileOptionTests.java b/common/src/test/java/bisq/common/config/ConfigFileOptionTests.java
@@ -33,4 +33,13 @@ public void whenOptionHasEscapedColons_thenTheyGetUnescaped() {
         assertThat(option.arg, equalTo("example.com:8080"));
         assertThat(option.toString(), equalTo("host1=example.com:8080"));
     }
+
+    @Test
+    public void whenOptionHasNoValue_thenItSetsEmptyValue() {
+        String value = "host1=";
+        ConfigFileOption option = ConfigFileOption.parse(value);
+        assertThat(option.name, equalTo("host1"));
+        assertThat(option.arg, equalTo(""));
+        assertThat(option.toString(), equalTo("host1="));
+    }
 }