Merge pull request #4056 from ripcurlx/fix-connection-closing-of-core…

…-node-detection

Remove redundant closing of connection

core/src/main/java/bisq/core/btc/nodes/LocalBitcoinNode.java

@@ -229,11 +229,10 @@ private Optional<VersionMessage> attemptHandshakeForVersionMessage() {
         var originalNioClientLoggerLevel = silence(NioClient.class);
         var originalNioClientManagerLoggerLevel = silence(NioClientManager.class);
 
-        NioClient client;
         try {
             log.info("Initiating attempt to connect to and handshake with a local " +
                     "Bitcoin node (which may or may not be running) on port {}.", port);
-            client = createClient(peer, port, CONNECTION_TIMEOUT);
+            createClient(peer, port, CONNECTION_TIMEOUT);
         } catch (IOException ex) {
             log.error("Local bitcoin node handshake attempt was unexpectedly interrupted", ex);
             return Optional.empty();
@@ -251,7 +250,6 @@ private Optional<VersionMessage> attemptHandshakeForVersionMessage() {
         }
 
         peer.close();
-        client.closeConnection();
 
         restoreLoggerLevel(NioClient.class, originalNioClientLoggerLevel);
         restoreLoggerLevel(NioClientManager.class, originalNioClientManagerLoggerLevel);