Refactor: rename methods, move return statement

bisq-network · Dec 15, 2020 · 26024bd · 26024bd
1 parent e0f4dc2
commit 26024bd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java b/core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
@@ -882,13 +882,13 @@ public boolean isSignWitnessTrade(Trade trade) {
                 tradeAmountIsSufficient(trade.getTradeAmount());
     }
 
-    public String signInfoFromAccount(PaymentAccount paymentAccount) {
+    public String getSignInfoFromAccount(PaymentAccount paymentAccount) {
         var pubKey = keyRing.getSignatureKeyPair().getPublic();
         var witness = getMyWitness(paymentAccount.getPaymentAccountPayload());
         return Utilities.bytesAsHexString(witness.getHash()) + "," + Utilities.bytesAsHexString(pubKey.getEncoded());
     }
 
-    public Tuple2<AccountAgeWitness, byte[]> signInfoFromString(String signInfo) {
+    public Tuple2<AccountAgeWitness, byte[]> getSignInfoFromString(String signInfo) {
         var parts = signInfo.split(",");
         if (parts.length != 2) {
             return null;
@@ -899,12 +899,11 @@ public Tuple2<AccountAgeWitness, byte[]> signInfoFromString(String signInfo) {
             var accountAgeWitnessHash = Utilities.decodeFromHex(parts[0]);
             pubKeyHash = Utilities.decodeFromHex(parts[1]);
             accountAgeWitness = getWitnessByHash(accountAgeWitnessHash);
+            return accountAgeWitness
+                    .map(ageWitness -> new Tuple2<>(ageWitness, pubKeyHash))
+                    .orElse(null);
         } catch (Exception e) {
             return null;
         }
-
-        return accountAgeWitness
-                .map(ageWitness -> new Tuple2<>(ageWitness, pubKeyHash))
-                .orElse(null);
     }
 }
diff --git a/desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java b/desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java
@@ -547,7 +547,7 @@ protected void copyAccount() {
         if (selectedAccount == null) {
             return;
         }
-        Utilities.copyToClipboard(accountAgeWitnessService.signInfoFromAccount(selectedAccount));
+        Utilities.copyToClipboard(accountAgeWitnessService.getSignInfoFromAccount(selectedAccount));
     }
 
 }

diff --git a/desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java b/desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java
@@ -94,7 +94,7 @@ private void addSelectWitnessContent() {
             if (newValue == null || newValue.isEmpty()) {
                 return;
             }
-            signInfo = accountAgeWitnessService.signInfoFromString(newValue);
+            signInfo = accountAgeWitnessService.getSignInfoFromString(newValue);
             if (signInfo == null) {
                 actionButton.setDisable(true);
                 return;
-Original file line number
+Diff line change
@@ Expand Up / @@ -547,7 +547,7 @@ protected void copyAccount() { @@
             if (selectedAccount == null) {
                 return;
             }
-            Utilities.copyToClipboard(accountAgeWitnessService.signInfoFromAccount(selectedAccount));
+            Utilities.copyToClipboard(accountAgeWitnessService.getSignInfoFromAccount(selectedAccount));
         }
     }
@@ Expand Down @@