Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby to v2.6.2 #330

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Update ruby to v2.6.2 #330

merged 1 commit into from
Jan 14, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Jan 10, 2020

Ruby 2.4 reaches EOL in March 2020.

It seems like Ruby does annual deprecations for their major versions, so 2.6 should be good through March 2022. This PR moves to 2.6.2, which is the only version of Ruby 2.6 that Netlify seems to fully support at the moment.

@m52go
Copy link
Contributor Author

m52go commented Jan 10, 2020

It seems Netlify is failing to build...will need to solve before this can be merged.

https://deploy-preview-330--bisq-website.netlify.com/

@m52go
Copy link
Contributor Author

m52go commented Jan 11, 2020

Turns out 2.6.5 isn't fully supported by Netlify...2.6.2 is the only one that works.

@m52go m52go changed the title Update ruby to v2.6.5 Update ruby to v2.6.2 Jan 11, 2020
Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@m52go m52go merged commit 58d838f into bisq-network:master Jan 14, 2020
@m52go m52go deleted the update-ruby-265 branch January 14, 2020 02:01
@m52go
Copy link
Contributor Author

m52go commented Jan 14, 2020

@ripcurlx FYI, just want to make sure you see this update, so you're not blindsided with an issue next time you update the site for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants