-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Google Fonts with self hosted fonts #324
Conversation
Thanks for tackling this! It looks good to me overall, but something isn't quite right with Japanese. Check the main page and DAO page as examples: font weight seems to be off, and some characters aren't rendered correctly in spite of the font being the same. Font weight example, current then proposed: Font rendering example, current then proposed (notice the character after "Bisq" text): These examples are from the "Join the Community" section on the bottom of the front page. |
Japanese doesn't use the latin script bro, you want Japanese "regular" for m plus 😉 |
I think it's because you're loading the IBM font on the Japanese site, you just need to use the "else" statement to only load the Japanese font (and not load the IBM font) on the Japanese site. |
@RiccardoMasutti if you add the japanese-latin font in one commit and remove it another, that font file will forever be included in the website repo, even tho we will never use it. can you squash those two commits together so the japanese-latin font is removed from the PR entirely? |
|
Right, but can you squash those commits into the commit that added the font file? Or simply squash all commits in this PR together will accomplish the same thing 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK but please squash commits before merging
Squashed. |
There was a conversation a couple of days ago with other website devs and one of them asked me if having Google Search Console installed would be privacy invading or not.
I replied by saying that privacy is already broken by embedding Google Fonts.
If we want to guarantee privacy to our users, it is necessary to remove Google Fonts and replace with self-hosted.
This PR replace Google Fonts with self hosted fonts on bisq.network website.
I have done several researches and spent many hours to make sure that this change does not detract from support for our users.
There are in fact different types of fonts. I decided to include only .woff and .woff2 (less heavy, faster website loading) which are supported from:
After a careful analysis of the website visits (differentiated by browser version) through Matomo, I came to the conclusion that this change affects ~ 0.01% of our users.
In fact, it has emerged that, from mid-August to today, only 114 users have used extremely obsolete browsers. In particular:
What happens if a user accesses the site with an unsupported browser?
It simply does not load our fonts but uses those of the operating system.
If this PR is approved, I will do the same for the documentation.