Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Google Fonts with self hosted fonts #324

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

RiccardoMasutti
Copy link
Contributor

@RiccardoMasutti RiccardoMasutti commented Jan 8, 2020

There was a conversation a couple of days ago with other website devs and one of them asked me if having Google Search Console installed would be privacy invading or not.
I replied by saying that privacy is already broken by embedding Google Fonts.

By using our APIs, you agree that Google can use submitted information in accordance with our privacy policies, such as http://www.google.com/privacypolicy.html

If we want to guarantee privacy to our users, it is necessary to remove Google Fonts and replace with self-hosted.
This PR replace Google Fonts with self hosted fonts on bisq.network website.

I have done several researches and spent many hours to make sure that this change does not detract from support for our users.
There are in fact different types of fonts. I decided to include only .woff and .woff2 (less heavy, faster website loading) which are supported from:

  • Firefox since version 3.6
  • Google Chrome since version 6.0
  • Internet Explorer since version 9
  • Konqueror since KDE 4.4.1
  • Microsoft Edge
  • Opera since version 11.10
  • Safari 5.1
  • other WebKit-based browsers since WebKit build 528

After a careful analysis of the website visits (differentiated by browser version) through Matomo, I came to the conclusion that this change affects ~ 0.01% of our users.

In fact, it has emerged that, from mid-August to today, only 114 users have used extremely obsolete browsers. In particular:

  • Internet Explorer <9 112
  • Safari <5.1 2

What happens if a user accesses the site with an unsupported browser?
It simply does not load our fonts but uses those of the operating system.

If this PR is approved, I will do the same for the documentation.

@m52go
Copy link
Contributor

m52go commented Jan 8, 2020

Thanks for tackling this! It looks good to me overall, but something isn't quite right with Japanese.

Check the main page and DAO page as examples: font weight seems to be off, and some characters aren't rendered correctly in spite of the font being the same.

Font weight example, current then proposed:

Screenshot from 2020-01-08 15-56-10

Screenshot from 2020-01-08 15-56-15

Font rendering example, current then proposed (notice the character after "Bisq" text):

Screenshot from 2020-01-08 15-58-34

Screenshot from 2020-01-08 15-58-40

These examples are from the "Join the Community" section on the bottom of the front page.

@wiz
Copy link
Contributor

wiz commented Jan 8, 2020

Japanese doesn't use the latin script bro, you want Japanese "regular" for m plus 😉

css/jafont.scss Outdated Show resolved Hide resolved
css/jafont.scss Outdated Show resolved Hide resolved
css/jafont.scss Outdated Show resolved Hide resolved
@wiz
Copy link
Contributor

wiz commented Jan 8, 2020

Thanks for tackling this! It looks good to me overall, but something isn't quite right with Japanese.

I think it's because you're loading the IBM font on the Japanese site, you just need to use the "else" statement to only load the Japanese font (and not load the IBM font) on the Japanese site.

@RiccardoMasutti RiccardoMasutti requested a review from wiz January 9, 2020 15:58
@wiz
Copy link
Contributor

wiz commented Jan 9, 2020

@RiccardoMasutti if you add the japanese-latin font in one commit and remove it another, that font file will forever be included in the website repo, even tho we will never use it. can you squash those two commits together so the japanese-latin font is removed from the PR entirely?

@RiccardoMasutti
Copy link
Contributor Author

@RiccardoMasutti if you add the japanese-latin font in one commit and remove it another, that font file will forever be included in the website repo, even tho we will never use it. can you squash those two commits together so the japanese-latin font is removed from the PR entirely?

Already done:
dcd9a5a
75cd0a9

@wiz
Copy link
Contributor

wiz commented Jan 9, 2020

Right, but can you squash those commits into the commit that added the font file? Or simply squash all commits in this PR together will accomplish the same thing 😅

Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but please squash commits before merging

@m52go
Copy link
Contributor

m52go commented Jan 10, 2020

Squashed.

@m52go m52go merged commit b7adc6d into bisq-network:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants