Fix Opengraph and Twitter tags #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
wiz
reviewed
Mar 9, 2020
| <meta property="twitter:site" content="{{ langdata.enabled }}"> | ||
| <meta property="twitter:site" content="https://bisq.network/"> | ||
| <meta property="twitter:description" content="{{ langdata.site_desc }}"> | ||
| <meta property="twitter:image" content="/images/bisq-og.jpg"> |
There was a problem hiding this comment.
Twitter cards do not support relative paths, and you have to use a fully-qualified HTTP(S) URL in the image tag.
Good job "fixing" the twitter tag, did you guys even test this? lol
The twitter card preview image is broken now :)
wiz
reviewed
Mar 9, 2020
| <meta property="twitter:site" content="{{ langdata.enabled }}"> | ||
| <meta property="twitter:site" content="https://bisq.network/"> | ||
| <meta property="twitter:description" content="{{ langdata.site_desc }}"> | ||
| <meta property="twitter:image" content="/images/bisq-og.jpg"> |
There was a problem hiding this comment.
Suggested change
| <meta property="twitter:image" content="/images/bisq-og.jpg"> | |
| <meta property="twitter:image" content="https://bisq.network/images/bisq-og.jpg"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
<meta property="og:url">,<meta property="twitter:description">and<meta property="twitter:image">tags as they were missing.Fixed
<meta property="twitter:site">as it was brokenMarking up content on Bisq website can: