-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change page titles: bisq is network not exchange #280
Conversation
Page titles across the site call Bisq "The decentralized Bitcoin exchange" which isn't really true...it's more of a network that serves as a means to exchange bitcoin. Also "the" sounds pretentious, as if it's the only entity of its kind that will ever exist, so it's changed to "a".
Motivated by changes done to the website, as described in bisq-network/bisq-website#280
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
I have also submitted a PR to update strings within the app.
bisq-network/bisq#3681
I like the "The". Marketing stuff? |
If this would be a company I would go for "The ..." as it is more common to set out big claims without the need to actually proof it 😉 . To reduce the troll attack vector I agree that a more humble approach might suite better for Bisq and changing away from a pure |
Since discussion is happening here, I'll copy my comment from bisq-network/bisq#3681: I'm not sure where/how "the exchange" wording originated, but I think it's pretentious and unusual. Debian - a free operating system (OS) for your computer (link) I'll wait to merge the website changes until this gets more consensus since it's a relatively meaningful change (i.e., definition of the project). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on the proposed changes plus a couple additional suggestions of my own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to add this comment to my review above, but it got lost in the process.
Based on feedback mentioned in this comment: bisq-network/bisq-website#280 (comment)
* Update strings to reflect bisq is exchange network Motivated by changes done to the website, as described in bisq-network/bisq-website#280 * Use lowercase 'bitcoin' Based on feedback mentioned in this comment: bisq-network/bisq-website#280 (comment)
Merging, as remaining issues have been addressed, and accompanying PR in bisq-network/bisq is merged now too. |
Page titles across the site call Bisq "The decentralized Bitcoin exchange" which doesn't sound right...it's more of a network that serves as a means to exchange bitcoin.
Also "the" sounds pretentious, as if it's the only entity of its kind that will ever exist, so it's changed to "a".