Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change page titles: bisq is network not exchange #280

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Nov 5, 2019

Page titles across the site call Bisq "The decentralized Bitcoin exchange" which doesn't sound right...it's more of a network that serves as a means to exchange bitcoin.

Also "the" sounds pretentious, as if it's the only entity of its kind that will ever exist, so it's changed to "a".

Page titles across the site call Bisq "The
decentralized Bitcoin exchange" which isn't
really true...it's more of a network that
serves as a means to exchange bitcoin.

Also "the" sounds pretentious, as if it's the
only entity of its kind that will ever exist,
so it's changed to "a".
devinbileck added a commit to devinbileck/bisq that referenced this pull request Nov 25, 2019
Motivated by changes done to the website, as described in
bisq-network/bisq-website#280
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
I have also submitted a PR to update strings within the app.
bisq-network/bisq#3681

@freimair
Copy link

I like the "The". Marketing stuff?

@ManfredKarrer @ripcurlx @sqrrm

@ripcurlx
Copy link
Contributor

If this would be a company I would go for "The ..." as it is more common to set out big claims without the need to actually proof it 😉 . To reduce the troll attack vector I agree that a more humble approach might suite better for Bisq and changing away from a pure exchange to a exchange network communicates more what Bisq is as well. So from my side 👍 . But as this might be a bigger change also for the future I'd like more contributors to give their opinion as well before merging. e.g. @cbeams

@m52go
Copy link
Contributor Author

m52go commented Nov 26, 2019

Since discussion is happening here, I'll copy my comment from bisq-network/bisq#3681:


I'm not sure where/how "the exchange" wording originated, but I think it's pretentious and unusual.

Debian - a free operating system (OS) for your computer (link)
Qubes - a reasonably secure operating system (link)
Bitcoin - an experimental digital currency (link)

I'll wait to merge the website changes until this gets more consensus since it's a relatively meaningful change (i.e., definition of the project).

Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the proposed changes plus a couple additional suggestions of my own.

_data/languages.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add this comment to my review above, but it got lost in the process.

_data/languages.yml Show resolved Hide resolved
devinbileck added a commit to devinbileck/bisq that referenced this pull request Nov 28, 2019
Based on feedback mentioned in this comment:
bisq-network/bisq-website#280 (comment)
ripcurlx added a commit to bisq-network/bisq that referenced this pull request Dec 3, 2019
* Update strings to reflect bisq is exchange network

Motivated by changes done to the website, as described in
bisq-network/bisq-website#280

* Use lowercase 'bitcoin'

Based on feedback mentioned in this comment:
bisq-network/bisq-website#280 (comment)
@m52go
Copy link
Contributor Author

m52go commented Dec 4, 2019

Merging, as remaining issues have been addressed, and accompanying PR in bisq-network/bisq is merged now too.

@m52go m52go merged commit caa6fdf into bisq-network:master Dec 4, 2019
@m52go m52go deleted the exchange-to-network branch December 4, 2019 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants