Localize site name/description for metadata preview pane usage

[wiz]

Allows you to localize the preview text on Slack, Twitter, etc. like this:

[erciccione]

utACK

[huey735]

@m52go Could we change the English text to:
site_desc: "Bisq is an open-source desktop application that allows you to buy and sell bitcoins in exchange for national currencies or altcoins."

pt-PT translation
site_name: "Bisq - A exchange de Bitcoin descentralizada"
site_desc: "Bisq é uma aplicação de desktop open-source que lhe permite comprar e vender bitcoins em troca de moedas nacionais ou altcoins."

[wiz]

why not "alternative crypto-currencies" ? too long?

[m52go]

@wiz yeah for such site previews, every character counts. Would be too long, I think.

I would say it could be shortened even more to "Bisq is an open-source desktop application that allows you to trade bitcoin for national currencies or altcoins."

[wiz]

The max length for opengraph description is 155 characters. The string "Bisq is an open-source desktop application that allows you to buy and sell bitcoins in exchange for national currencies, or alternative crypto currencies." is 154 characters so it fits perfectly, and I don't see any issue?

[m52go]

No issues, but I would still say shorter is better, like how a 50-character tweet is more likely to be read entirely than a 240-character tweet.

I don't have a strong opinion here...it was just a suggestion. Maybe others can chime in.

[wiz]

Of course, you need to fit your translated text within the 155 character limit, so by all means shorten your translations if necessary. I think it's important to say "alternative crypto-currency" and not "altcoins" because newbies might not know what those are.

[m52go]

test

EDIT: I suggested some changes but they didn't get added to my review. Will try to submit review again.

[wiz]

you can't suggest changes if I already committed and pushed them 😉

[m52go]

I prefer this wording.

[wiz]

IMO your requested changes are out of scope for this PR. This PR is only to implement the ability to localize the description into various languages, not to change any strings. If you want to change strings, you should do that in your own PR, not in mine :)

[m52go]

You're on thin ice here buddy. But I acknowledge this contribution 😄

[m52go]

ACK