Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update software stats version and outdated_translation vars #228

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Sep 5, 2019

Mostly small text/front-matter corrections.

@m52go
Copy link
Contributor Author

m52go commented Sep 5, 2019

Merging, as the corrections are minor but important.

@m52go m52go merged commit be5e5a1 into bisq-network:master Sep 5, 2019
@erciccione
Copy link
Contributor

I'm a bit worried by the fact that merge requests get merged so fast. I understand that these are minor corrections, but they are many and this repo depolys directly to the website. I would be more cautious as the bisq project grows bigger and i would wait at least for one review, or 24 hours, before merging :).

@m52go m52go deleted the small-corrections branch September 6, 2019 11:53
@m52go
Copy link
Contributor Author

m52go commented Sep 6, 2019

@erciccione unlike with the software, my heuristic for merges in this repository are based on 1) subjectivity and/or 2) functional changes (i.e., stuff that may break the site). If the merge has even a modicum of subjectivity or functional effect, I always wait for at least 1 review before merging.

This request was all typos/text which met neither condition above.

But this is mainly for expediency, as until recently there weren't any other regular contributors to this repository to give reviews. As that number increases, it may make sense to wait for feedback on requests like this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants