Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate volume by fiat and altcoin #226

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Separate volume by fiat and altcoin #226

merged 2 commits into from
Sep 5, 2019

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Sep 4, 2019

No description provided.

erciccione
erciccione suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats.html page of the other languages need to to be updated too and would be better to put the text string in a variable, so that can be picked up easily by the other languages.

Add fiat-altcoin change to all stats pages
853912e 
Also use variable for chart caption text.
@m52go
Copy link
Contributor Author

m52go commented Sep 4, 2019

Done. Thanks @erciccione, bad oversight on my part.

@m52go m52go merged commit 25a220b into bisq-network:master Sep 5, 2019
@m52go m52go deleted the separate-altcoin-fiat branch September 5, 2019 12:20
@erciccione erciccione mentioned this pull request Sep 9, 2019
Closed
This was referenced Sep 9, 2019
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erciccione erciccione erciccione requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m52go @erciccione