Remove version variable from downloads page #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On @m52go's advice I changed the construction of the outdated translation alert toolto be spefic to the page instead of the language. I added a "outdated_translation" variable to the front matter of the relevant translated pages. They'll have the values 'true' or 'false' according to the state.
This was referenced Aug 26, 2019
Closed
wiz
reviewed
Aug 26, 2019
|
|
||
| <!-- Outdated translation alert tool tag--> | ||
| {% if page.outdated_translation %} | ||
| <span class="navbar-text" style="color: orange;">Outdated translation</span> |
There was a problem hiding this comment.
It looks like this is doing more than simply removing a variable from the downloads page?
There was a problem hiding this comment.
@wiz I decided to put this commit in this PR because it also affects the downloads pages. It felt wrong to remove the 'version' variables in one PR and then add 'outdated_translations' in another PR when they overlap files.
|
|
This reverts commit 9e49594. Remove unnecessary commit as changes are already present in the master branch.
huey735
commented
Aug 26, 2019
|
New and better PR #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.