Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage update - adding URLs to "Download for x" #216

Merged
merged 2 commits into from
Aug 25, 2019

Conversation

RajaMBZ
Copy link
Contributor

@RajaMBZ RajaMBZ commented Aug 24, 2019

When I very first viewed the homepage, I clicked the "Download for Windows" button ten times before realizing that it's not linked with any URL. This update fixes that.

Copy link
Contributor

@huey735 huey735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes need to also be done to /_includes/homepage_content_tr.html so that they affect the translated pages.

@RajaMBZ
Copy link
Contributor Author

RajaMBZ commented Aug 25, 2019

Done

@m52go
Copy link
Contributor

m52go commented Aug 25, 2019

ACK

@m52go
Copy link
Contributor

m52go commented Aug 25, 2019

Thank you @RajaMBZ!

Nits: in the future, please make your changes on another branch (i.e., one that's not called master) and use these conventions for writing git commits (mainly, start with a verb in the imperative form).

@m52go m52go merged commit 61772bc into bisq-network:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants