Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post: summary of first 4 dao cycles #211

Merged
merged 4 commits into from
Aug 28, 2019

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Aug 23, 2019

I am aware that the site header doesn't work correctly on blog post pages. I'm working on a fix now, and will not merge this post until that is fixed (EDIT: here is PR with fix).

But in the mean time, a review of this post would be great!

Please pay special attention to lines 41 and 43 about seed nodes to make sure they are accurate.

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Minor things.

_posts/2019-08-22-bisq-dao-first-four-cycles.md Outdated Show resolved Hide resolved
_posts/2019-08-22-bisq-dao-first-four-cycles.md Outdated Show resolved Hide resolved
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
Very good summary! Content looks good to me. I did not verify the numbers.

_posts/2019-08-22-bisq-dao-first-four-cycles.md Outdated Show resolved Hide resolved
Steve Jain and others added 2 commits August 28, 2019 08:41
Typo, youtube-nocookie for embed.
Co-Authored-By: Devin Bileck <[email protected]>
@m52go
Copy link
Contributor Author

m52go commented Aug 28, 2019

@erciccione @devinbileck thanks for the feedback!

@m52go m52go merged commit a2ed07e into bisq-network:master Aug 28, 2019
@m52go m52go deleted the first-dao-report branch August 28, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants