Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile notifications links on home page #205

Merged
merged 3 commits into from
Aug 21, 2019

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Aug 11, 2019

The iOS link on the home page was going to the Google Play store.

@huey735 I also shortened some of the texts for the mobile app download buttons. Could you check them to make sure they look ok? For Portugese for example, the text may not be gramatically perfect, but do you think it will work?

Before

iosNotificationApp: Baixar App de Notificação para iOS

Screenshot from 2019-08-11 16-14-03

After

iosNotificationApp: iOS App de Notificação

Screenshot from 2019-08-11 16-13-48

Steve Jain added 2 commits August 11, 2019 16:03
On homepage, because it was too long to fit on 375px screen.
Copy link
Contributor

@huey735 huey735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Portuguese "App de Notificação IOS" and "App de Notificação Android" is better. I assume it's similar in Spanish but can't be sure. Please also update the strings inside _data/strins_en.yml.

@m52go
Copy link
Contributor Author

m52go commented Aug 21, 2019

@huey735 thanks, updated. The strings in _data/strings_en.yml don't change. This change was merely to shorten the existing strings so they fit on mobile screens (original meaning stayed the same).

Copy link
Contributor

@huey735 huey735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for es and pt-PT

@m52go m52go merged commit a74b9ce into bisq-network:master Aug 21, 2019
@m52go m52go deleted the fix-ios-link branch August 21, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants