Add Chinese, German and Spanish translations #202
Conversation
_layouts/default.html
Outdated
| @@ -733,7 +733,7 @@ | |||
| <body class="home page-template-default page page-id-6 custom-background"> | |||
|
|
|||
| <!--Select includes/main_nav according to page lang or absence of lang--> | |||
| {% if page.lang == "pt-PT" %} | |||
| {% if page.lang == "de" or page.lang == "es" or page.lang == "pt-PT" or page.lang == "zh-CN" %} | |||
There was a problem hiding this comment.
To avoid adding languages to the condition every time...with lots of languages, this will quickly get unwieldy.
How about this?
{% if page.lang == "en" %}
{% include main_nav.html %}
{% else %}
{% include main_nav_tr.html %}
{% endif %}
There was a problem hiding this comment.
I reworked it to look like this:
{% if page.lang == "en" or page.ref == "blog" %}
{% include main_nav.html %}
{% else %}
{% include main_nav_tr.html %}
{% endif %}
Otherwise the Blog page doesn't render a nav bar.
_data/es.yml
Outdated
| pJoin: > | ||
| <p>Bisq siempre está buscando desarrolladores altamente cualificados, diseñadores y expertos en seguridad para unirse a nuestra <a href="localhost:4001/community/">comunidad</a>. Si está interesado en ayudar a mejorar Bisq, hay muchas maneras de<a href="https://docs.bisq.network/contributor-checklist.html" target="_blank" rel="noopener">contribuir</a>. | ||
| Nos encantaría<a href="localhost:4001/community/">saber de ti</a>!</p> | ||
| <p>Nuestra <a href="localhost:4001/roadmap/">hoja de ruta</a> proporciona una vista general de las características y hitos hasta llegar a la v.1.0. de Bisq</p> |
There was a problem hiding this comment.
Looks like the period at the end of the sentence is misplaced:
hasta llegar a la v.1.0 de Bisq.
_data/es.yml
Outdated
| <li class="mt-0 mb-4 pb-4 border-bottom step step-text-2" data-image="step-image-2">Añada sus cuentas de moneda nacional o cripto</li> <li class="mt-0 mb-4 pb-4 border-bottom step step-text-3" data-image="step-image-3">Cree una nueva oferta o tome una existente.</li> <li class="mt-0 step step-text-4" data-image="step-image-4">Siga la interfaz de usuario para finalizar el intercambio.</li> | ||
| hJoin: Unirse a la comunidad | ||
| pJoin: > | ||
| <p>Bisq siempre está buscando desarrolladores altamente cualificados, diseñadores y expertos en seguridad para unirse a nuestra <a href="localhost:4001/community/">comunidad</a>. Si está interesado en ayudar a mejorar Bisq, hay muchas maneras de<a href="https://docs.bisq.network/contributor-checklist.html" target="_blank" rel="noopener">contribuir</a>. |
There was a problem hiding this comment.
I don't know the language but it seems like there are missing spaces around the links here.
Notice "maneras decontribuir" and "Nos encantaríasaber de ti".
| seeMore: > | ||
| <p>Weitere Ressourcen finden Sie in unserem <a href='https://docs.bisq.network/dao.html'>Alles über die Bisq DAO</a> Dokument.</p> <p>Bisherige Mitwirkende finden in <a href='https://docs.bisq.network/compensation.html#get-added-to-genesis'>diesem Link</a> Anweisungen, wie sie der Genesis BSQ-Distribution hinzugefügt werden können.</p> | ||
| downloads: | ||
| hBisqDownloads: Bisq Downloads |
There was a problem hiding this comment.
runningWindows
runningMac
runnigDebian
runningRedHat
Need to remove the periods here, otherwise, they result in a double period. Also check pt-PT.yml. I think the others are fine.
The runningOS keys in the homepage_content section can have periods, but the runningOS keys in the downloads section shouldn't.
If you want to keep it simple you could just remove periods from all runningOS keys...the homepage_content doesn't really need periods anyway.
There was a problem hiding this comment.
Can you show me where the strings for the "running" keys appear on the website? I guess it isn't detecting on my computer.
There was a problem hiding this comment.
Yeah it's on the Downloads page at the end of the sentence where it says "You appear to be using..."
This is ok, no double period:
This has a double period:
Only a problem for de and pt-pt though...you won't see it for any other language.
There was a problem hiding this comment.
Oh, thanks. Chrome doesn't display it for some reason here, but it does show up on Firefox.
I reworked the Liquid control flow tags to include the nav bar. Now, pages where "lang: en" or "ref: blog" will include the English nav bar while everywhere else will include a nav bar according to its language.
Co-Authored-By: Steve Jain <[email protected]>
|
ACK |
I translated the images in the DAO page and renamed the image files accordingly.