-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate website to Portuguese #190
Conversation
Hi @huey735, sorry for the delay...I've been traveling and I'm on holiday this upcoming week. I've cloned your repository and will check it out as I can. For now, two small things:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the "_tr" suffix to signal that they're the translated versions
I think this approach is confusing. Wouldn't be better to have a folder called i18n
or something like that, where put all the translations? There could be a folder called pt-pt
and all the portuguese translations could go in there, same for the other languages.
could we change the pt_PT directory to just pt? I think it would help URLs would look cleaner.
I agree with @huey735, better use pt_PT, it's a better standard and avoid problems in the future (same potential issue with Chinese)
do we want to keep URLs in English?
I think they should be kept in english.
@erciccione due to Jekyll (or my understand of it) certain files need to stay on certain folders so I figured it'd be better to keep them next to original and just add the suffix "_tr" to highlight that they're the translated versions. And these files won't relate to a single language. I'm still learning Jekyll and Liquid and I followed this suggested method - sylvaindurand.org/making-jekyll-multilingual/. It seems less intrusive than other methods available for translation. I've been looking at them and maybe in the future with a reconstruction of the website other methods will be more appropriate.
|
Looks good to me overall. My biggest concern remains long-term maintainability, but I think that can only be rectified by formatting all website content in markdown instead of HTML (e.g., that's how the plugin @erciccione suggested seems to work).
Understood...I didn't realize some languages will need more than one option. Could we turn the underscore into a dash (e.g., pt_PT to pt-PT)? I think it looks a lot cleaner, and the vast majority of our URLs and redirects use dashes.
I went back and checked the call...looks like we agreed to keep URLs in English? See this clip from the last translator call: https://youtu.be/K1TG-_ISj2w?t=2220 Looking at other sites, that seems to be the standard. It also seems more intuitive to me. |
Sure |
@huey735 looks good. I just resolved a merge conflict related to the software release from yesterday. One item: I noticed in two places there's a Front Matter attribute |
@huey735 for future reference...GitHub does weird things when the name of the branch you want to merge is also called Next time please call your forked branch something other than |
@m52go can you point me to these front matters? Sorry for the poor naming of the branch. |
@huey735 just added comments. I didn't fix myself because I wasn't sure if they were connected to something else. |
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
ACK |
Create duplicates of:
/_data/
dao_content.yml
main_nav.yml
/_includes/
footer.html
homepage_content.html
main_nav.html
os_selector_options.html
Add the "_tr" suffix to signal that they're the translated versions and adapt the files inside /_includes/ to link the translated pages and strings.
Add pt_PT.yml inside /_data/ with the translated strings from .html files.
Change functions in /_layouts/default.html to accommodate for new languages.
Add "ref", "lang" and "language" variables to the web pages to be translated and copy them into a folder named after the respective language's code (the same specified in "lang") :
/community.md
/dao.html
/downloads.html
/faq.html
/index.md
/markets.html
/stats.html
/vision.md
Copy also /images/DAO and re-render the images with the translated strings.