-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use post build plugin #7
Merged
bisq-github-admin-3
merged 14 commits into
bisq-network:main
from
ghubstan:use-post-build-plugin
Jul 26, 2022
Merged
Use post build plugin #7
bisq-github-admin-3
merged 14 commits into
bisq-network:main
from
ghubstan:use-post-build-plugin
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes v 7.4.2 bug: some misleading warnings about task dependencies
TODO Create new PR to change .gitmodules content [submodule "bisq-gradle"] path = bisq-gradle url = https://github.com/ghubstan/bisq-gradle.git branch = add-post-build-task TO [submodule "bisq-gradle"] path = bisq-gradle url = https://github.com/bisq-network/bisq-gradle.git We need to wait until PR bisq-network/bisq-gradle#1 to be approved & merged before making the above change to .gitmdoules
TODO Test service installation again after PR merge. TODO Test scripts with bisq-monitor service dependency Wating for merge (new PR) for branch https://github.com/ghubstan/bisq-monitor/tree/add-gradle-task-submodule
Is being replaced by bisq-network's bisq-gradle plugin because PR bisq-network/bisq-gradle#2 has been merged.
Seems to be blocked only for me, in my region
ripcurlx
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports pre-compiled script plugin
bisq.post-build
instead of custom taskpostBuild
.Based on #6