Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Don't encourage literally anyone to join Bisq org on GitHub #156

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Aug 25, 2019

It's not a good idea to encourage people to “ask to be added to bisq organization on github” in the new contributor checklist. If they are going to be assigned issues or some role/responsibility then they should be invited to join, but just letting literally anyone become a member of the Bisq org on GitHub is a security risk. If I just show up to Google's front door, they won't give me a security badge if I ask for one.

We should also audit the list of organization members and remove people who have never been assigned any issues/roles, never submitted any pull-requests, etc. - being a member of the organization is a trusted position, because anyone can claim they are representing Bisq to external third parties with this membership.

I propose we just add a simple requirement "when you are going to be assigned something" in front of the “ask to be added to bisq organization on github” checklist.

@battleofwizards
Copy link

ACK (tested)

I cannot agree more with this.

The proposed fix vastly improves the situation. However, the text can still leave an impression that it is required to get assigned to an issue. I would suggest either adding a comment that it is optional or maybe removing the chapter "Getting assigned to an issue or role" entirely. Maybe it is simply not on the newcomer's to-do.

@m52go
Copy link
Contributor

m52go commented Aug 25, 2019

Agreed, this practice become suboptimal over time. Before when it was mainly developers sporadically joining, it worked better. Thanks wiz.

@m52go m52go merged commit d4c64ac into bisq-network:master Aug 25, 2019
@wiz wiz deleted the github-org-wtf branch August 25, 2019 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants