Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

Fix bug with Sepa offers and Sepa instant taker #117

Closed
ManfredKarrer opened this issue Jun 5, 2018 · 0 comments
Closed

Fix bug with Sepa offers and Sepa instant taker #117

ManfredKarrer opened this issue Jun 5, 2018 · 0 comments

Comments

@ManfredKarrer
Copy link
Contributor

The handling of Sepa an Sepa instant accounts is not correct.
There are 2 bugs:

  1. If the offer is SEPA and the the taker has a SEPA INSTANT account and takes that offer the cehck of the contract fails on the maker side and lead to lost taker fee on the takers side.

  2. If a maker creates an offer with a SEPA INSTANT account a taker with a SEPA account can take it. This should not be allowed as the maker would expect an instant transfer but the taker has only a SEPA account.
@ManfredKarrer ManfredKarrer mentioned this issue Jun 5, 2018
Merged
ManfredKarrer added a commit that referenced this issue Jun 6, 2018
@ManfredKarrer
Merge pull request #118 from ManfredKarrer/fix-sepa-account-bug
703b223 
Fixes #117
@ManfredKarrer ManfredKarrer changed the title Bug with Sepa offers and Sepa instant taker Fix bug with Sepa offers and Sepa instant taker Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ManfredKarrer