Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Debian version #204

Closed
wants to merge 1 commit into from
Closed

Update Docker Debian version #204

wants to merge 1 commit into from

Conversation

hyp0dermik-code
Copy link
Contributor

See #203

Merge after #201 and #202

Copy link

Build artifacts:

@hyp0dermik-code
Copy link
Contributor Author

hyp0dermik-code commented Jul 24, 2024

This will likely break the current Github build environment and require the regeneration of the .wine folder

Docker image grows by 600MB from 1.2GB to 1.8GB

@stylesuxx
Copy link
Contributor

Could you rebase this branch on latest develop please?

@stylesuxx
Copy link
Contributor

stylesuxx commented Jul 24, 2024

@saidinesh5 will updating the Dockerfile trigger automatic re-generation builder package?

I would not like to fiddle with that if we can keep it in working condition, I remember that the initial setup was a bit of a PITA...

Copy link

Build artifacts:

@saidinesh5
Copy link
Contributor

We pushed the builder container manually to the repo iirc. But yeah let's avoid the docker file update ..

@hyp0dermik-code
Copy link
Contributor Author

We pushed the builder container manually to the repo iirc. But yeah let's avoid the docker file update ..

So there would be technically no harm in updating the Docker file?

The disadvantage is it makes the environment harder to replicate, but the need to change the Dockerfile can be documented in the meantime

Shall we close it and document it for the meantime, and I'll leave the issue open for further investigation?

Copy link

Build artifacts:

@stylesuxx
Copy link
Contributor

Yeah, if we pushed it manually, then there should not be a problem. For now let's leave this issue open.

I am not too familiar with the package part and how it is supposed to regenerate things. Since we do not have an action that is doing anything to it, I'd guess it won't update - unless there is some magic happening that I am unaware of.

@hyp0dermik-code hyp0dermik-code closed this by deleting the head repository Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants