Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drs_filename creates unncessary failures #103

Closed
huard opened this issue Mar 12, 2020 · 7 comments
Closed

drs_filename creates unncessary failures #103

huard opened this issue Mar 12, 2020 · 7 comments
Assignees
@nilshempelmann @davidcaron

Comments

@huard
Copy link
Collaborator

huard commented Mar 12, 2020

Description

A process using drs_filename will fail if the project is not hard-coded in finch. I don't think this is reasonable. We should try to rename files, but if it doesn't work, still get a response.

Environment

  • finch version used, if any: 0.4.4
  • Python version, if any:
@huard
Copy link
Collaborator Author

huard commented Mar 12, 2020

See Ouranosinc/PAVICS-e2e-workflow-tests#37

@tlvu
Copy link
Collaborator

tlvu commented Mar 12, 2020

Direct link to relevant comment: Ouranosinc/PAVICS-e2e-workflow-tests#37 (comment)

@davidcaron davidcaron modified the milestone: 0.5.0 Mar 12, 2020
@davidcaron
Copy link
Collaborator

I will fix it, along with #69 and release a bug fix version.

@huard
Copy link
Collaborator Author

huard commented Mar 12, 2020

Thanks !

@nilshempelmann
Copy link
Member

@davidcaron: great!
May be this helps:
https://eggshell.readthedocs.io/en/latest/_modules/eggshell/nc/nc_utils.html#drs_filename
or:
https://eggshell.readthedocs.io/en/latest/_modules/eggshell/nc/nc_utils.html#sort_by_filename

@davidcaron davidcaron mentioned this issue Mar 12, 2020
Merged
@davidcaron
Copy link
Collaborator

@huard @tlvu v0.4.1 should be building in dockerhub

@huard
Copy link
Collaborator Author

huard commented Mar 12, 2020

Merci !

tlvu added a commit to bird-house/birdhouse-deploy that referenced this issue Mar 12, 2020
@tlvu
finch: update to 0.4.1
7f62856 
To get fix for issue bird-house/finch#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilshempelmann nilshempelmann

@davidcaron davidcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@huard @nilshempelmann @tlvu @davidcaron