-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading (non-bijective) prefix maps #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
changed the title
Reconciling non-bijective prefix maps
Upgrading non-bijective prefix maps
Jan 16, 2024
cthoyt
changed the title
Upgrading non-bijective prefix maps
Upgrading (non-bijective) prefix maps
Jan 16, 2024
joeflack4
reviewed
Jan 16, 2024
|
||
|
||
def upgrade_prefix_map(prefix_map: Mapping[str, str]) -> List[Record]: | ||
"""Convert a (potentially problematic) prefix map (i.e., not bijective) into a list of records. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how thorough your docstrings are.
@@ -2191,3 +2194,85 @@ def _get_shacl_line(prefix: str, uri_prefix: str, pattern: Optional[str] = None) | |||
pattern = pattern.replace("\\", "\\\\") | |||
line += f'; sh:pattern "{pattern}"' | |||
return line + " ]" | |||
|
|||
|
|||
def upgrade_prefix_map(prefix_map: Mapping[str, str]) -> List[Record]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm sure your test passes as well, but I ran it locally on my own and worked for me as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by mapping-commons/sssom-py#485. Demo:
This function is for people who are not in the position to make the sustainable fix, and want to automate
the assignment of which is the preferred prefix. It uses a deterministic algorithm to choose from two or more
CURIE prefixes that have the same URI prefix and generate an extended prefix map in which they have bene collapsed
into a single record. More specitically, the algorithm is based on a case-sensitive lexical sort of the prefixes.
The first in the sort order becomes the primary prefix and the others become synonyms in the resulting record.
cc @joeflack4